From owner-cvs-all@FreeBSD.ORG  Tue Apr  6 11:34:18 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id ADFCE16A4CE
	for <cvs-all@FreeBSD.org>; Tue,  6 Apr 2004 11:34:18 -0700 (PDT)
Received: from root.org (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 857CC43D48
	for <cvs-all@FreeBSD.org>; Tue,  6 Apr 2004 11:34:18 -0700 (PDT)
	(envelope-from nate@root.org)
Received: (qmail 28688 invoked by uid 1000); 6 Apr 2004 18:33:29 -0000
Date: Tue, 6 Apr 2004 11:33:29 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: Lukas Ertl <le@FreeBSD.org>
In-Reply-To: <20040406194620.P631@korben>
Message-ID: <20040406113129.T28582@root.org>
References: <200404031740.i33HeKH6016345@repoman.freebsd.org>
 <20040403184246.GA613@darkness.comp.waw.pl> <20040406194620.P631@korben>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Pawel Jakub Dawidek <pjd@FreeBSD.org>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sbin/growfs Makefile debug.c growfs.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 18:34:18 -0000

On Tue, 6 Apr 2004, Lukas Ertl wrote:
> On Sat, 3 Apr 2004, Pawel Jakub Dawidek wrote:
>
> > On Sat, Apr 03, 2004 at 09:40:20AM -0800, Lukas Ertl wrote:
> > +> le          2004/04/03 09:40:20 PST
> > +>
> > +>   FreeBSD src repository
> > +>
> > +>   Modified files:
> > +>     sbin/growfs          Makefile debug.c growfs.c
> > +>   Log:
> > +>   Make growfs WARNS=6 clean.
> >
> > AFAIK growfs(8) doesn't work with UFS2, so maybe while you are here... :)
>
> It works on UFS2, but not very well.  Yes, I'll have a look, but maybe
> I'll make a big style sweep first, so I can actually read what's going on
> there. :-)

It does work but there are problems.  First thing that should be done is
factor out the superblock update code and have growfs bring it up to
canonical (latest) form before processing the fs.  Also, there are minor
things like it removing flags like ACLs from the superblock.

-Nate