From owner-svn-src-all@freebsd.org  Sun Oct 25 16:55:45 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 76FB88108;
 Sun, 25 Oct 2015 16:55:45 +0000 (UTC) (envelope-from kp@FreeBSD.org)
Received: from venus.codepro.be (venus.codepro.be [IPv6:2a01:4f8:162:1127::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits))
 (Client CN "*.codepro.be", Issuer "Gandi Standard SSL CA 2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 3D89412BC;
 Sun, 25 Oct 2015 16:55:45 +0000 (UTC) (envelope-from kp@FreeBSD.org)
Received: from [IPv6:2a02:1811:2419:4e02:f98e:1278:f825:1dc6] (unknown
 [IPv6:2a02:1811:2419:4e02:f98e:1278:f825:1dc6])
 by venus.codepro.be (Postfix) with ESMTPSA id 95DE2225D8;
 Sun, 25 Oct 2015 17:55:41 +0100 (CET)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\))
Subject: Re: svn commit: r289932 - head/sys/net
From: Kristof Provost <kp@FreeBSD.org>
In-Reply-To: <1445791710.91534.51.camel@freebsd.org>
Date: Sun, 25 Oct 2015 17:55:38 +0100
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <DD88137A-1BC7-42B1-A646-CAE3DF7B2DA5@FreeBSD.org>
References: <201510251314.t9PDEsV6053440@repo.freebsd.org>
 <1445791710.91534.51.camel@freebsd.org>
To: Ian Lepore <ian@freebsd.org>
X-Mailer: Apple Mail (2.3096.5)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Oct 2015 16:55:45 -0000


> On 25 Oct 2015, at 17:48, Ian Lepore <ian@freebsd.org> wrote:
>=20
> On Sun, 2015-10-25 at 13:14 +0000, Kristof Provost wrote:
>> Author: kp
>> Date: Sun Oct 25 13:14:53 2015
>> New Revision: 289932
>> URL: https://svnweb.freebsd.org/changeset/base/289932
>>=20
>> Log:
>>  PF_ANEQ() macro will in most situations returns TRUE comparing two
>> identical
>=20
> It looks like this change is causing warnings when compiled with gcc:
>=20
> cc1: warnings being treated as errors
> /local/build/staging/freebsd/dpcur/src/sys/netpfil/pf/if_pfsync.c: In =
function 'pfsync_state_import':
> /local/build/staging/freebsd/dpcur/src/sys/netpfil/pf/if_pfsync.c:467: =
warning: suggest parentheses around && within || [-Wparentheses]
> /local/build/staging/freebsd/dpcur/src/sys/netpfil/pf/if_pfsync.c:468: =
warning: suggest parentheses around && within || [-Wparentheses]
> --- if_pfsync.o ---
> *** [if_pfsync.o] Error code 1
>=20
> (and many more just the same building other pf files).
Ouch, yes, it looks like I messed that up.

The fix is on its way.

Regards,
Kristof=