From owner-freebsd-emulation@FreeBSD.ORG Mon Aug 7 01:12:14 2006 Return-Path: X-Original-To: freebsd-emulation@FreeBSD.org Delivered-To: freebsd-emulation@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E25A16A4DD for ; Mon, 7 Aug 2006 01:12:14 +0000 (UTC) (envelope-from acm@FreeBSD.org) Received: from mail8.hsphere.cc (mail8.hsphere.cc [216.157.145.28]) by mx1.FreeBSD.org (Postfix) with ESMTP id 540A643D49 for ; Mon, 7 Aug 2006 01:12:13 +0000 (GMT) (envelope-from acm@FreeBSD.org) Received: (qmail 13554 invoked by uid 89); 7 Aug 2006 01:12:12 -0000 Received: from unknown (HELO HellFire.BSD.org.pe) (acardenas@bsd.org.pe@201.230.21.30) by mail8.hsphere.cc with SMTP; 7 Aug 2006 01:12:11 -0000 Date: Sun, 6 Aug 2006 20:12:16 -0500 From: Jose Alonso Cardenas Marquez To: Boris Samorodov Message-Id: <20060806201216.2e569321.acm@FreeBSD.org> In-Reply-To: <82654251@bsam.ru> References: <200608041438.k74Ec3Wr096494@repoman.freebsd.org> <20060804195623.564c8a6e@Magellan.Leidinger.net> <20060804203725.efb1e8df.acm@FreeBSD.org> <36280092@bs2.sp34.ru> <95145875@bsam.ru> <20060806174543.62b15d3d.acm@FreeBSD.org> <82654251@bsam.ru> Organization: FreeBSD X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.20; i386-portbld-freebsd6.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Alexander Leidinger , freebsd-emulation@FreeBSD.org, garga@FreeBSD.org Subject: Re: cvs commit: ports/ftp Makefile ports/ftp/linux-curl Makefile distinfo.i386 X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Aug 2006 01:12:14 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Mon, 07 Aug 2006 04:03:16 +0400 Boris Samorodov wrote: > On Sun, 6 Aug 2006 17:45:43 -0500 Jose Alonso Cardenas Marquez wrote: > > On Sun, 06 Aug 2006 15:15:08 +0400 > > Boris Samorodov wrote: > > Why did you use @dirrmtry at security/linux-krb5-libs/pkg-plist? ;-) > Actually, it seems to me that when in doubt you prefer to use @dirrmty > macro. I'd say that it should be quite the opposite. This macro should > be used only when you are sure that those directories are shared > between ports and there is no (so to say) "master port" which deals > with those directories. My opinion is to use @dirrmtry with care... Fixed. Maybe i don't need to work on security/linux-krb5-libs anymore, because it could be on linux_base-fc4 soon ;) > Good work! And here are some comments: > - you didn't show a diff for the distinfo; > - portrevision is not bumpted; ;-) > - at pkg-install script only empty directories are created, so there > is no need to create a usr/kerberos one; > - assume that you didn't check linux_base-fc4.diff file on TB, because > I can't manage to find a line with "@dirrm usr/kerberos" at the > plist file. I fixed all these points, you can see the TB log files. http://hellfire.no-ip.org/tb/logs/4-STABLE/linux_base-fc-4_7.log http://hellfire.no-ip.org/tb/logs/5-STABLE/linux_base-fc-4_7.log http://hellfire.no-ip.org/tb/logs/6-STABLE/linux_base-fc-4_7.log http://tb3.droso.net/logs/6-acm/linux_base-fc-4_7.log and the new diff file http://hellfire.no-ip.org/ports/linux_base-fc4.diff > Other than that seems OK. May be Alexander has something to add. > Thanks! If every things are ok, i'll send one PR with this patch. Thanks for your support :) Greetings - ---- Jose Alonso Cardenas Marquez | http://www.FreeBSD.org acm@FreeBSD.org | http://www.BSD.org.pe GnuPG Key: http://www.FreeBSD.org/~acm/pgp/pubkey.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFE1pNwGV/UqJshvBkRAlUxAJwLVtGcNPaUhoG6lrP2iVCd50riTwCbBKHk ubj+5rulyAKPnEgnCMTkacM= =VAHC -----END PGP SIGNATURE-----