Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 May 2012 23:16:29 +0000 (UTC)
From:      Marcel Moolenaar <marcel@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r235041 - head/sys/ia64/ia64
Message-ID:  <201205042316.q44NGTUM027293@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: marcel
Date: Fri May  4 23:16:29 2012
New Revision: 235041
URL: http://svn.freebsd.org/changeset/base/235041

Log:
  Don't assume we have legacy PICs (i.e. 8259A in cascade) at the legacy
  I/O port addresses. Even if we do, this is hardly the place to mask
  interrupts. It's not clear that this was at all needed. The code came
  with CVS revision 1.2 of nexus.c when interrupt support was first added.
  What is known is that ia64 has always been designed around the IOSAPIC,
  and that doing I/O like this prevents Altix from booting.

Modified:
  head/sys/ia64/ia64/nexus.c

Modified: head/sys/ia64/ia64/nexus.c
==============================================================================
--- head/sys/ia64/ia64/nexus.c	Fri May  4 22:54:54 2012	(r235040)
+++ head/sys/ia64/ia64/nexus.c	Fri May  4 23:16:29 2012	(r235041)
@@ -65,9 +65,6 @@
 
 #include <dev/acpica/acpivar.h>
 
-#include <isa/isareg.h>
-#include <sys/rtprio.h>
-
 #include "clock_if.h"
 
 static MALLOC_DEFINE(M_NEXUSDEV, "nexusdev", "Nexus device");
@@ -191,12 +188,6 @@ static int
 nexus_attach(device_t dev)
 {
 
-	/*
-	 * Mask the legacy PICs - we will use the I/O SAPIC for interrupt.
-	 */
-	outb(IO_ICU1+1, 0xff);
-	outb(IO_ICU2+1, 0xff);
-
 	if (acpi_identify() == 0)
 		BUS_ADD_CHILD(dev, 10, "acpi", 0);
 	clock_register(dev, 1000);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201205042316.q44NGTUM027293>