From owner-svn-src-head@FreeBSD.ORG  Thu Mar  4 12:14:29 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4E4AE1065673;
	Thu,  4 Mar 2010 12:14:29 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.freebsd.org (Postfix) with ESMTP id 0A0848FC22;
	Thu,  4 Mar 2010 12:14:28 +0000 (UTC)
Received: from [IPv6:::1] (pooker.samsco.org [168.103.85.57])
	by pooker.samsco.org (8.14.2/8.14.2) with ESMTP id o24CENwi001628;
	Thu, 4 Mar 2010 05:14:23 -0700 (MST)
	(envelope-from scottl@samsco.org)
Mime-Version: 1.0 (Apple Message framework v1077)
Content-Type: text/plain; charset=us-ascii
From: Scott Long <scottl@samsco.org>
In-Reply-To: <20100304120250.GN8200@hoeg.nl>
Date: Thu, 4 Mar 2010 05:14:23 -0700
Content-Transfer-Encoding: 7bit
Message-Id: <20920CE7-2963-45F2-8D64-E36FBAAFE369@samsco.org>
References: <200906152105.n5FL50Ju001949@svn.freebsd.org>
	<CADA450C-C67C-47DA-BF64-40FFE011B1E9@samsco.org>
	<20100304053221.GL8200@hoeg.nl>
	<20100304044516.R1188@pooker.samsco.org>
	<20100304120250.GN8200@hoeg.nl>
To: Ed Schouten <ed@80386.nl>
X-Mailer: Apple Mail (2.1077)
X-Spam-Status: No, score=-4.5 required=3.8 tests=ALL_TRUSTED,AWL,BAYES_00
	autolearn=ham version=3.1.8
X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r194266 - head/usr.bin/chpass
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Mar 2010 12:14:29 -0000

On Mar 4, 2010, at 5:02 AM, Ed Schouten wrote:
> * Scott Long <scottl@samsco.org> wrote:
>> What do you mean by "unconditionally"?  Most of the utilities that
>> install themselves with 'chflags schg' do so by unconditionally
>> ignoring errors. Chpass seems to be the only exception at the
>> moment.
> 
> No, I mean, don't set schg unconditionally. NO_FSCHG should still work
> afterwards. All applications currently honour this. If you create a
> FreeBSD jail and run `make installworld' a second time while inside the
> jail, this currently works, because there is not a single file which has
> schg set, which means `make installworld' can overwrite everything.
> 

Does this look good?

===================================================================
--- Makefile	(revision 204639)
+++ Makefile	(working copy)
@@ -43,7 +43,7 @@

.if !defined(NO_FSCHG)
afterinstall:
-	chflags schg ${DESTDIR}${BINDIR}/chpass
+	-chflags schg ${DESTDIR}${BINDIR}/chpass
.endif

.include <bsd.prog.mk>