From owner-svn-src-all@FreeBSD.ORG Tue Nov 4 10:55:02 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F32298F2; Tue, 4 Nov 2014 10:55:01 +0000 (UTC) Received: from theravensnest.org (theraven.freebsd.your.org [216.14.102.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cloud.theravensnest.org", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id C3BF7B39; Tue, 4 Nov 2014 10:55:01 +0000 (UTC) Received: from c116.sec.cl.cam.ac.uk (c116.sec.cl.cam.ac.uk [128.232.18.116]) (authenticated bits=0) by theravensnest.org (8.14.9/8.14.9) with ESMTP id sA4AsuwA060332 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Tue, 4 Nov 2014 10:54:58 GMT (envelope-from theraven@FreeBSD.org) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r274086 - head/sbin/route From: David Chisnall In-Reply-To: <20141104102828.GB1215@mole.fafoe.narf.at> Date: Tue, 4 Nov 2014 10:54:56 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201411041021.sA4ALZ4m001202@svn.freebsd.org> <20141104102828.GB1215@mole.fafoe.narf.at> To: Stefan Farfeleder X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, "Alexander V. Chernikov" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Nov 2014 10:55:02 -0000 On 4 Nov 2014, at 10:28, Stefan Farfeleder wrote: > Shouldn't Coverity understand that err doesn't return? err() is marked as __dead2, which expands to = __attribute__((__noreturn__)). If Coverity doesn't know that = __attribute__((__noreturn__)) functions don't return, then that's a = Coverity bug and they should fix it (if we're not expanding __dead3 to = __attribute__((__noreturn__)) for Coverity, then that's a sys/cdefs.h = bug and should be fixed there). =20 Putting a break after a noreturn function makes the code less readable = and will cause errors in non-buggy static analysers (dead code warning - = why do you have a break on an unreachable line?). David