From owner-p4-projects@FreeBSD.ORG  Sun Apr 26 17:36:34 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 629801065672; Sun, 26 Apr 2009 17:36:34 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2259E106564A
	for <perforce@freebsd.org>; Sun, 26 Apr 2009 17:36:34 +0000 (UTC)
	(envelope-from zec@fer.hr)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 118BE8FC1E
	for <perforce@freebsd.org>; Sun, 26 Apr 2009 17:36:34 +0000 (UTC)
	(envelope-from zec@fer.hr)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n3QHaXQQ055046
	for <perforce@freebsd.org>; Sun, 26 Apr 2009 17:36:33 GMT
	(envelope-from zec@fer.hr)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n3QHaXBY055044
	for perforce@freebsd.org; Sun, 26 Apr 2009 17:36:33 GMT
	(envelope-from zec@fer.hr)
Date: Sun, 26 Apr 2009 17:36:33 GMT
Message-Id: <200904261736.n3QHaXBY055044@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	zec@fer.hr using -f
From: Marko Zec <zec@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 161116 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 26 Apr 2009 17:36:35 -0000

http://perforce.freebsd.org/chv.cgi?CH=161116

Change 161116 by zec@zec_amdx2 on 2009/04/26 17:36:10

	Access from userland to igmpstat is provided via a sysctl
	(which is already V_irtualized).  Hence, there's no need
	for kmem / kldsym kludges, so vnet_igmp_symmap can go away.
	If not, it should be added to vnet_inet_symmap, because
	struct vnet_igmp doesn't exist anyway.
	
	XXX why was igi_head ever put in vnet_iugmp_symmap?

Affected files ...

.. //depot/projects/vimage-commit/src/sys/netinet/igmp.c#15 edit

Differences ...

==== //depot/projects/vimage-commit/src/sys/netinet/igmp.c#15 (text+ko) ====

@@ -3620,19 +3620,6 @@
 	return (0);
 }
 
-/*
- * XXX Are igi_head and igmpstat really accessed via kmem / kldsym?
- * If so, given that they are members of struct vnet_inet, they should
- * be registered with VNET_MOD_INET, not here.  Revisit!!!
- */
-#if 0
-static struct vnet_symmap vnet_igmp_symmap[] = {
-	VNET_SYMMAP(igmp, igi_head),
-	VNET_SYMMAP(igmp, igmpstat),
-	VNET_SYMMAP_END
-};
-#endif
-
 #ifndef VIMAGE_GLOBALS
 static vnet_modinfo_t vnet_igmp_modinfo = {
 	.vmi_id		= VNET_MOD_IGMP,