From nobody Wed Jan 14 08:06:10 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4drdwf5DL3z6PLCd for ; Wed, 14 Jan 2026 08:06:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4drdwf4J3kz3KNY for ; Wed, 14 Jan 2026 08:06:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768377970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yMwkfsm17N/ZH1MhPBiaohhMn17+lPMxdG3hOHBKRxw=; b=Uq2rFYOzIiONPBHHxCiif6miF+DTtnivA42mUXYeKwkJMeZ2nRMEvh8+fqRhHpIC0Svuqk H3En3cYasSlagZZdy5vFV7EjDWP5kLSbyJM+ww1Xo7JJk+TDXr6u03dUKKgQqgGwZ7jXbK RpsmPFn2SrtEuaF8fM0h7ASeSwpQOBbef+hmAOSmTWZboQheYAq1sMFQnUpcI5sVGzs/C5 nzDJoQzH2UKXxZ/OtqiCSJ5OQCPUYVJrEKQ1/XGoZSSWX2OdFgsXmuAirgz3cn0uXMpcgo UVpoXc5xy1D/Ky1/UXtk1hF/WCpt/WUV7GGGhlq4hC2FbHwU3YuxPLQwwQ7JUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768377970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yMwkfsm17N/ZH1MhPBiaohhMn17+lPMxdG3hOHBKRxw=; b=L8m9yVGDcDM3WO2EIYIHi04MhOSCRsDScqsKsBRTqLbajoHuGSyIAkgO4ayQhe1LNeODMW uusH3gJedAHLi0YZ0zKwrOa0KHioOfBo0/kgrYjqmqosGESvMNsmtENzWQKK27EU5G7GMq hWQ3EF47Ca0PauR4529uUzkY4+BOdbut41UvvT223g4l7vFfTWOdedB6MyPbA3vDjqlq0Q n/cB9tLQjc9EBAlZsEtzVstYOvMOF+M/2ccVoQUYfiYDaXZzgNuh1UQRPJoMvD6KTnokRi E5ctswPM6TEHpqL/Phsd/bsLO+M8TLQjGa1WkLlD/bUfVzWU45z77VrZTCTlsg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768377970; a=rsa-sha256; cv=none; b=CQ5RBFcLwY6tvFZ9zBdyCcoSU73wINCLll5/JAfXs7QdkchU3FsZT8zUpyTDbf8th1o5O+ aNNOdN0WW7lFjrc+EkTb7/8m92o1ShEOpe1Cm0ry0njKHRy5jZUP0M4dcCtzPV1OGw6wfs IzXJ8qqiEZxSYL59d+MIJfNZthnigDxEFBosMNdstjp7sWXJpYcw2nF04ut9OxFSuKC5YJ JO5pmKhI8xs89ugy1h9n7q+ziULwsXrsGvSISnkk1/8ANg0dMWrftRqmgT6cOubKacGR48 /Tql6Ike08jIwGCbrL9iX/2RxJuB8RBY/q1S/g7uOlNLTgsbpk1zWKzO3pw5Pg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4drdwf36QPzqmt for ; Wed, 14 Jan 2026 08:06:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id c70f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 14 Jan 2026 08:06:10 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: f2d2d6f010e4 - main - pf: remove redundant range checks List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f2d2d6f010e48410a4435f73aa60ad3dcefccd3b Auto-Submitted: auto-generated Date: Wed, 14 Jan 2026 08:06:10 +0000 Message-Id: <69674e72.c70f.2910426@gitrepo.freebsd.org> The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=f2d2d6f010e48410a4435f73aa60ad3dcefccd3b commit f2d2d6f010e48410a4435f73aa60ad3dcefccd3b Author: Kristof Provost AuthorDate: 2026-01-12 15:59:22 +0000 Commit: Kristof Provost CommitDate: 2026-01-14 06:44:41 +0000 pf: remove redundant range checks the range checks are not needed because both members (statelim and sourcelim) are uint8_t, they implicitly fit desired range <0, 255>. Unbreaks gcc build. Pointed out by deraadt@ OK deraadt@ Obtained from: OpenBSD, sashan , 3a7be1e428 Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/netpfil/pf/pf_ioctl.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/sys/netpfil/pf/pf_ioctl.c b/sys/netpfil/pf/pf_ioctl.c index bc998113dbbb..f6040e2f03a8 100644 --- a/sys/netpfil/pf/pf_ioctl.c +++ b/sys/netpfil/pf/pf_ioctl.c @@ -2950,18 +2950,6 @@ pf_ioctl_addrule(struct pf_krule *rule, uint32_t ticket, if (pf_validate_range(rule->dst.port_op, rule->dst.port)) ERROUT_UNLOCKED(EINVAL); - if (rule->statelim != PF_STATELIM_ID_NONE) { - if (rule->statelim < PF_STATELIM_ID_MIN || - rule->statelim > PF_STATELIM_ID_MAX) - ERROUT_UNLOCKED(EINVAL); - } - - if (rule->sourcelim != PF_SOURCELIM_ID_NONE) { - if (rule->sourcelim < PF_SOURCELIM_ID_MIN || - rule->sourcelim > PF_SOURCELIM_ID_MAX) - ERROUT_UNLOCKED(EINVAL); - } - if (rule->ifname[0]) kif = pf_kkif_create(M_WAITOK); if (rule->rcv_ifname[0])