From owner-svn-ports-all@freebsd.org Tue Jul 16 18:09:55 2019 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 42283B6B4F; Tue, 16 Jul 2019 18:09:55 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mouf.net", Issuer "mouf.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 792626D50D; Tue, 16 Jul 2019 18:09:54 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from lrrr.mouf.net (cpe-174-109-174-192.nc.res.rr.com [174.109.174.192]) (authenticated bits=0) by mouf.net (8.14.9/8.14.9) with ESMTP id x6GI9kW4087211 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Tue, 16 Jul 2019 18:09:52 GMT (envelope-from swills@FreeBSD.org) Subject: Re: svn commit: r506329 - head/multimedia/libva To: Jan Beich , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201907100116.x6A1GDuA002773@repo.freebsd.org> From: Steve Wills Message-ID: <554d91d4-b243-a73b-9761-57c7da31a8ce@FreeBSD.org> Date: Tue, 16 Jul 2019 14:09:41 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <201907100116.x6A1GDuA002773@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mouf.net [199.48.129.64]); Tue, 16 Jul 2019 18:09:52 +0000 (UTC) X-Spam-Status: No, score=0.0 required=4.5 tests=none autolearn=unavailable autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mouf.net X-Virus-Scanned: clamav-milter 0.99.2 at mouf.net X-Virus-Status: Clean X-Rspamd-Queue-Id: 792626D50D X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.88 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-0.97)[-0.972,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.91)[-0.913,0]; ASN(0.00)[asn:36236, ipnet:2607:fc50::/36, country:US] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jul 2019 18:09:55 -0000 Hi, On 7/9/19 9:16 PM, Jan Beich wrote: > Author: jbeich > Date: Wed Jul 10 01:16:13 2019 > New Revision: 506329 > URL: https://svnweb.freebsd.org/changeset/ports/506329 > > Log: > multimedia/libva: drop -lpthread on FreeBSD 11.4/12.1/13.0 > > libva doesn't use threads unless LIBVA_TRACE is passed via environment. > > PR: 238650 > > Modified: > head/multimedia/libva/Makefile (contents, props changed) > > Modified: head/multimedia/libva/Makefile > ============================================================================== > --- head/multimedia/libva/Makefile Wed Jul 10 01:16:04 2019 (r506328) > +++ head/multimedia/libva/Makefile Wed Jul 10 01:16:13 2019 (r506329) > @@ -19,7 +19,11 @@ USES= meson pkgconfig > USE_GITHUB= yes > USE_LDCONFIG= yes > GH_ACCOUNT= intel > -LDFLAGS+= -lpthread # for pthread_getthreadid_np > +# -lpthread is not necessary if pthread_getthreadid_np is a libc stub > +LDFLAGS+= ${LDFLAGS_${OPSYS}_${OSREL}} > +LDFLAGS_FreeBSD_11.2= -lpthread > +LDFLAGS_FreeBSD_11.3= -lpthread > +LDFLAGS_FreeBSD_12.0= -lpthread > > OPTIONS_DEFINE= GLX WAYLAND X11 > OPTIONS_DEFAULT=GLX WAYLAND X11 > This broke the build for me, running CURRENT r348454 in my jail. Do I need to update my jail? Cheers, Steve