From owner-freebsd-current@FreeBSD.ORG  Sun Aug 19 16:32:06 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7BA96106566C
	for <freebsd-current@freebsd.org>; Sun, 19 Aug 2012 16:32:06 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe09.c2i.net [212.247.155.2])
	by mx1.freebsd.org (Postfix) with ESMTP id 06FB98FC0A
	for <freebsd-current@freebsd.org>; Sun, 19 Aug 2012 16:32:05 +0000 (UTC)
X-T2-Spam-Status: No, hits=-0.2 required=5.0 tests=ALL_TRUSTED,
	BAYES_50
Received: from [176.74.212.201] (account mc467741@c2i.net HELO
	laptop015.hselasky.homeunix.org)
	by mailfe09.swip.net (CommuniGate Pro SMTP 5.4.4)
	with ESMTPA id 135029756; Sun, 19 Aug 2012 18:31:56 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
To: Andrew Turner <andrew@fubar.geek.nz>,
 freebsd-current@freebsd.org
Date: Sun, 19 Aug 2012 18:32:39 +0200
User-Agent: KMail/1.13.7 (FreeBSD/9.1-PRERELEASE; KDE/4.8.4; amd64; ; )
References: <20120819202622.6db6a8dd@fubar.geek.nz>
	<zarafa.5030d8f9.78da.3793f9461199bff8@eric2.bitfrost>
In-Reply-To: <zarafa.5030d8f9.78da.3793f9461199bff8@eric2.bitfrost>
X-Face: 'mmZ:T{)),Oru^0c+/}w'`gU1$ubmG?lp!=R4Wy\ELYo2)@'UZ24N@
	=?iso-8859-1?q?d2+AyewRX=7DmAm=3BYp=0A=09=7CU=5B?=@,
	_z/([?1bCfM{_"B<.J>mICJCHAzzGHI{y7{%JVz%R~yJHIji`y>
	=?iso-8859-1?q?Y=7Dk1C4TfysrsUI=0A=09-=25GU9V5=5DiUZF=26nRn9mJ=27=3F=26?=>O
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201208191832.39569.hselasky@c2i.net>
Cc: 
Subject: Recent changes in AT91 kernel code causes USB to not work [WAS:
	r239214 - in head/sys: dev/usb dev/usb/controller sys]
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 19 Aug 2012 16:32:06 -0000

Hi,

I'm trying to reproduce using "src/sys/KB920X arm".

So far the platform doesn't boot, because recent commits removed one ore more 
of these clocks:

        sc->sc_iclk = at91_pmc_clock_ref("udc_clk");
        sc->sc_fclk = at91_pmc_clock_ref("udpck");

So I get a crash at a NULL pointer when trying to access one of these clocks.

How to fix this?

I simply added a NULL check. Now the platform hangs when setting up the OHCI:

sys/dev/usb/controller/ohci_atmelarm.c

+       printf("CLOCK ON\n");
        at91_pmc_clock_enable(sc->iclk);
        at91_pmc_clock_enable(sc->fclk);
        bus_space_write_4(sc->sc_ohci.sc_io_tag, sc->sc_ohci.sc_io_hdl,
            OHCI_CONTROL, 0);

+       printf("INIT\n");

I see the clock ON printout, and then nothing more! Not sure if this is caused 
by IRQ's hanging or not.

Andrew Turner: Can you fix these issues so that I can reproduce?

--HPS