From owner-cvs-all@FreeBSD.ORG Tue Aug 10 15:44:07 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 62D9316A5BC; Tue, 10 Aug 2004 15:44:07 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9762043D39; Tue, 10 Aug 2004 15:44:06 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i7AFhlY6088699 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 10 Aug 2004 18:43:48 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.12.11/8.12.11) id i7AFhnVl020020; Tue, 10 Aug 2004 18:43:49 +0300 (EEST) (envelope-from ru) Date: Tue, 10 Aug 2004 18:43:48 +0300 From: Ruslan Ermilov To: John-Mark Gurney Message-ID: <20040810154348.GA19937@ip.net.ua> References: <200408090645.i796jLUo046034@repoman.freebsd.org> <20040810122307.GA18408@ip.net.ua> <20040810144913.GO991@funkthat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OXfL5xGRrasGEqWY" Content-Disposition: inline In-Reply-To: <20040810144913.GO991@funkthat.com> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys mdioctl.h src/sys/modules/md Makefile src/sbin/mdconfig mdconfig.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Aug 2004 15:44:07 -0000 --OXfL5xGRrasGEqWY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 10, 2004 at 07:49:13AM -0700, John-Mark Gurney wrote: > Ruslan Ermilov wrote this message on Tue, Aug 10, 2004 at 15:23 +0300: > > On Mon, Aug 09, 2004 at 06:45:21AM +0000, John-Mark Gurney wrote: > > > jmg 2004-08-09 06:45:21 UTC > > >=20 > > > FreeBSD src repository > > >=20 > > > Modified files: > > > sys/sys mdioctl.h=20 > > > sys/modules/md Makefile=20 > > > sbin/mdconfig mdconfig.c=20 > > > Log: > > > change the name of the md module, to g_md, introduce a define with = the > > > name MD_MODNAME, and make mdconfig use this new define... > > > =20 > > > Revision Changes Path > > > 1.33 +1 -1 src/sbin/mdconfig/mdconfig.c > > > 1.13 +1 -1 src/sys/modules/md/Makefile > > > 1.16 +1 -0 src/sys/sys/mdioctl.h > > >=20 > > Why the change in the first place? >=20 > so that mdconfig does not try to load the md kernel module twice, and > cause your machine to panic. >=20 > With a recent commit of phk's to md that converts it to geom, he removed > the previous DECLARE_MODULE w/ the name of md, and so the md module was > no longer implementing the md module, only the g_md module. On my box > that is using mfs, mdconfig would then try to load the md module a > second time causing geom to panic. >=20 Thanks a bunch for explaining! > I then realized that since md is now a full on geom module, it should > be renamed to geom_md like all the other geom modules... I still need > to ask cvs@ to repo copy the module Makefiles into modules/geom/md... >=20 Yes, please. I wondered about this too (why it was not named geom_md). Another thing I'm worried about is that it's typical for a "device foo" to have the corresponding foo.ko module, and now this is no longer the case. I think many would still prefer that the file be named md.ko, while clearly the inside module should be named "g_md". Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --OXfL5xGRrasGEqWY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFBGO00qRfpzJluFF4RAprgAJ43GACTXFFI5iJa7a8eIlkXv8OvzgCfVOcK x8FJFKzt0ac1ALmGyKd2ELE= =8JUz -----END PGP SIGNATURE----- --OXfL5xGRrasGEqWY--