From owner-svn-src-all@FreeBSD.ORG Fri Apr 6 21:21:29 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BAD611065670; Fri, 6 Apr 2012 21:21:29 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id A50B48FC19; Fri, 6 Apr 2012 21:21:28 +0000 (UTC) Received: by lbok6 with SMTP id k6so1211867lbo.13 for ; Fri, 06 Apr 2012 14:21:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=iNxEiF8Q57++hoMj0Xors1t8qgRVrKf5NKDTDEtTszM=; b=NJWwZpKAy+mWs0LdxhmnalG4x0JBKN78/yXSSLwPy4i4KGj39YTPwOlI+RQDu0aDeC paoDo7l7lXTctY63dq7jFzaE0zkR4amPZ/1yPE1z5uJ9bMsVW3EkX/mBgVpwo9cTxKU1 wz2ZoXKxj4v4mXjc+I9vbB4rnM2PuIIc+uZA0QOZdHVj5hR+G7yQh8xXwI98z0yTgqMP 7RDHMCuyjKV9uKUbmdycCYrgCOwtVafaL2TT+FsPeI+2NgyqVe9Q1C3miaU6LytkY75L OxqTfoX/P2jG7v9xGHmv3Mc0fQYhqTwJDKI8XIXzBkOOiZJhX9uyPyE+Pzmz4U40ZNZe z8Bw== MIME-Version: 1.0 Received: by 10.152.105.211 with SMTP id go19mr10479628lab.51.1333747287387; Fri, 06 Apr 2012 14:21:27 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.112.93.138 with HTTP; Fri, 6 Apr 2012 14:21:27 -0700 (PDT) In-Reply-To: <201204062119.q36LJTKR026564@svn.freebsd.org> References: <201204062119.q36LJTKR026564@svn.freebsd.org> Date: Fri, 6 Apr 2012 22:21:27 +0100 X-Google-Sender-Auth: OlN9Z-mELb7lKlauMfWP4w7uXhg Message-ID: From: Attilio Rao To: "Justin T. Gibbs" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r233961 - head/sys/x86/x86 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2012 21:21:29 -0000 Il 06 aprile 2012 22:19, Justin T. Gibbs ha scritto: > Author: gibbs > Date: Fri Apr =C2=A06 21:19:28 2012 > New Revision: 233961 > URL: http://svn.freebsd.org/changeset/base/233961 > > Log: > =C2=A0Fix interrupt load balancing regression, introduced in revision > =C2=A0222813, that left all un-pinned interrupts assigned to CPU 0. > > =C2=A0sys/x86/x86/intr_machdep.c: > =C2=A0 =C2=A0 =C2=A0 =C2=A0In intr_shuffle_irqs(), remove CPU_SETOF() cal= l that initialized > =C2=A0 =C2=A0 =C2=A0 =C2=A0the "intr_cpus" cpuset to only contain CPU0. > > =C2=A0 =C2=A0 =C2=A0 =C2=A0This initialization is too late and nullifies = the results of calls > =C2=A0 =C2=A0 =C2=A0 =C2=A0the intr_add_cpu() that occur much earlier in = the boot process. > =C2=A0 =C2=A0 =C2=A0 =C2=A0Since "intr_cpus" is statically initialized to= the empty set, and > =C2=A0 =C2=A0 =C2=A0 =C2=A0all processors, including the BSP, already add= themselves to > =C2=A0 =C2=A0 =C2=A0 =C2=A0"intr_cpus" no special initialization for the = BSP is necessary. For instance, the SETOF is not necessary here because set_interrupt_apic_ids() already does intr_add_cpu() for BSP too. Attilio --=20 Peace can only be achieved by understanding - A. Einstein