Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Apr 2023 22:50:22 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 271028] [New Port] devel/gum: Write useful shell scripts and dotfiles aliases with a few lines of code
Message-ID:  <bug-271028-7788-Cl4vatdy0V@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-271028-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-271028-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271028

--- Comment #4 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for your update.  The port builds fine.

Please check the formatting of the port Makefile.  The minimum indentation
level for values is two tab stops, even if the variable name fits into one.=
=20
You can use the portfmt utility to fix the formatting.

Also check if you can use GO_MODULE to avoid having to list all the
dependencies explicitly.  With GO_MODULE, the Go tooling automatically finds
and downloads the distfile and all dependencies.  So USE_GITHUB and all
dependencies can be omitted.

If the project ships a license file, check if you can set LICENSE_FILE.  Sh=
ould
be something like

    LICENSE_FILE=3D  ${WRKSRC}/...

There's no need to gzip the man page yourself.  Just install the man page
uncompressed but list the compressed page in the plist.  An automatic
post-install hook will compress it for you.

Please use DISTVERSION instead of PORTVERSION if possible.

PS: make sure to tick the "patch" checkbox when submitting a patch.  This w=
ay,
you can view it directly from Bugzilla.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-271028-7788-Cl4vatdy0V>