From owner-freebsd-bluetooth@FreeBSD.ORG  Tue Dec  1 19:15:25 2009
Return-Path: <owner-freebsd-bluetooth@FreeBSD.ORG>
Delivered-To: freebsd-bluetooth@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2DD3F1065692
	for <freebsd-bluetooth@freebsd.org>;
	Tue,  1 Dec 2009 19:15:25 +0000 (UTC)
	(envelope-from plunky@rya-online.net)
Received: from smtp6.freeserve.com (smtp6.freeserve.com [193.252.22.190])
	by mx1.freebsd.org (Postfix) with ESMTP id E434E8FC0A
	for <freebsd-bluetooth@freebsd.org>;
	Tue,  1 Dec 2009 19:15:24 +0000 (UTC)
Received: from me-wanadoo.net (localhost [127.0.0.1])
	by mwinf3633.me.freeserve.com (SMTP Server) with ESMTP id 83BF8700008D; 
	Tue,  1 Dec 2009 20:15:23 +0100 (CET)
Received: from me-wanadoo.net (localhost [127.0.0.1])
	by mwinf3633.me.freeserve.com (SMTP Server) with ESMTP id 73F7C70000D2; 
	Tue,  1 Dec 2009 20:15:23 +0100 (CET)
Received: from rya-online.net (unknown [89.194.129.131])
	by mwinf3633.me.freeserve.com (SMTP Server) with SMTP id 15FA1700008D; 
	Tue,  1 Dec 2009 20:15:21 +0100 (CET)
X-ME-UUID: 20091201191522901.15FA1700008D@mwinf3633.me.freeserve.com
Received: (nullmailer pid 11248 invoked by uid 1000);
	Tue, 01 Dec 2009 19:15:48 -0000
Date: Tue, 1 Dec 2009 19:15:48 +0000 (GMT)
To: Matthias Drochner <m.drochner@googlemail.com>
In-Reply-To: <20091201125054.44a00147@zelz27>
References: <20091201125054.44a00147@zelz27>
User-Agent: Alpine 2.00 (NEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Message-Id: <1259694948.961003.27487.nullmailer@galant.ukfsn.org>
From: Iain Hibbert <plunky@rya-online.net>
Cc: freebsd-bluetooth@freebsd.org
Subject: Re: patch to make obexapp work with BSD iconv(3)
X-BeenThere: freebsd-bluetooth@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Using Bluetooth in FreeBSD environments
	<freebsd-bluetooth.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bluetooth>, 
	<mailto:freebsd-bluetooth-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bluetooth>
List-Post: <mailto:freebsd-bluetooth@freebsd.org>
List-Help: <mailto:freebsd-bluetooth-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bluetooth>, 
	<mailto:freebsd-bluetooth-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Dec 2009 19:15:25 -0000

On Tue, 1 Dec 2009, Matthias Drochner wrote:

>  iconv_open(3), this is more robust than trying to interpret
>  the locale string

btw nl_langinfo(3) is defined to always return a valid pointer, so the

	if (locale == NULL)
		return (-1);

is not required..

also, the locale variable can be private to obexapp_util_locale_init() as
it is not used elsewhere

regards,
iain