From owner-freebsd-current  Tue Mar 25 04:15:13 1997
Return-Path: <owner-current>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id EAA08709
          for current-outgoing; Tue, 25 Mar 1997 04:15:13 -0800 (PST)
Received: from bsd.fs.bauing.th-darmstadt.de (bsd.fs.bauing.th-darmstadt.de [130.83.63.241])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id EAA08699;
          Tue, 25 Mar 1997 04:15:02 -0800 (PST)
Received: from campa.panke.de (anonymous213.ppp.cs.tu-berlin.de [130.149.17.213])
	by bsd.fs.bauing.th-darmstadt.de (8.8.5/8.8.5) with SMTP id NAA04769;
	Tue, 25 Mar 1997 13:14:57 +0100 (MET)
Received: (from wosch@localhost) by campa.panke.de (8.6.12/8.6.12) id MAA00909; Tue, 25 Mar 1997 12:54:03 +0100
Date: Tue, 25 Mar 1997 12:54:03 +0100
Message-Id: <199703251154.MAA00909@campa.panke.de>
From: Wolfram Schneider <wosch@apfel.de>
To: asami@vader.cs.berkeley.edu (Satoshi Asami)
Cc: wosch@freebsd.org, current@freebsd.org, mita@jp.FreeBSD.org
Subject: -current uudecode can't grok one of japanese/vfxdvi's distfiles
In-Reply-To: <199703250726.XAA01567@silvia.HIP.Berkeley.EDU>
References: <199703250726.XAA01567@silvia.HIP.Berkeley.EDU>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Sender: owner-current@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

Satoshi Asami writes:
>uudecode:
>        input file: stdin
>        encoded file: xdvi-pl17+markpage+toc+printdvi+paper.patch.gz
>        character out of range: [33-96]
>Do a boundary check for body characters. Characters less than 33 or
>greater than 96 are out of range. If characters are out of range
>uudecode print a error message and die.
>
>Is this check really necessary?  

Yes. All characters outside the range are garbage/bitrot and
you get undefined results. 


>This file used to decode fine with
>the old decoder.  Besides, I can't figure out for the life of myself
>which character it's barfing on.

It use spaces (ASCII 32) in body. Spaces are bad because
some mailers delete blank lines. Our uuencode never create
spaces. See 'The UNIX-HATERS Handbook', page 82-83

I can add character 32 to the valid range for compatibility with old
uuencode programs.

--
Wolfram Schneider    <wosch@apfel.de>    http://www.apfel.de/~wosch/