From owner-freebsd-hackers Tue Jan 21 20:57:45 2003 Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 194AF37B401 for ; Tue, 21 Jan 2003 20:57:44 -0800 (PST) Received: from sasami.jurai.net (sasami.jurai.net [66.92.160.223]) by mx1.FreeBSD.org (Postfix) with ESMTP id 203D843ED8 for ; Tue, 21 Jan 2003 20:57:43 -0800 (PST) (envelope-from winter@jurai.net) Received: from sasami.jurai.net (sasami.jurai.net [66.92.160.223]) by sasami.jurai.net (8.12.6/8.12.5) with ESMTP id h0M4vevA098042; Tue, 21 Jan 2003 23:57:40 -0500 (EST) (envelope-from winter@jurai.net) Date: Tue, 21 Jan 2003 23:57:40 -0500 (EST) From: "Matthew N. Dodd" To: Matthew Dillon Cc: hackers@FreeBSD.ORG, Hiten Pandya Subject: Re: patch to remove random #define MIN/MAX implementations from around the kernel In-Reply-To: <200301220325.h0M3PiNt099890@apollo.backplane.com> Message-ID: <20030121235501.N59276-100000@sasami.jurai.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 21 Jan 2003, Matthew Dillon wrote: > This patch is going to go in on the weekend unless someone has any > worthwhile nits about it. It was submitted by Hiten Pandya. > > The patch basically removes random MIN/MAX implementations from > 22 files in the kernel and modifies the one in sys/param.h (see the > last part of the patch) so it is present for all kernel builds. I'd like to see all of these changed to the inlines in sys/libkern.h since the compiler will do type checking for us. This is a little more work which is why I didn't do it myself when I dealt with the abs() stuff. Consider this my objection. I don't think that it really stands in the way of the cleanup of all the definitions of min/max etc. -- | Matthew N. Dodd | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD | | winter@jurai.net | 2 x '84 Volvo 245DL | ix86,sparc,pmax | | http://www.jurai.net/~winter | For Great Justice! | ISO8802.5 4ever | To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message