From owner-freebsd-net Tue Apr 25 8:51: 8 2000 Delivered-To: freebsd-net@freebsd.org Received: from dustdevil.waterspout.com (fourier.physics.purdue.edu [128.210.146.43]) by hub.freebsd.org (Postfix) with ESMTP id 84DCB37BF28; Tue, 25 Apr 2000 08:51:04 -0700 (PDT) (envelope-from csg@dustdevil.waterspout.com) Received: (from csg@localhost) by dustdevil.waterspout.com (8.9.3/8.9.3) id KAA00674; Tue, 25 Apr 2000 10:59:26 -0500 (EST) (envelope-from csg) Date: Tue, 25 Apr 2000 10:59:26 -0500 From: "C. Stephen Gunn" To: Archie Cobbs Cc: Julian Elischer , pavel@alum.mit.edu, nsayer@sftw.com, luigi@FreeBSD.ORG, freebsd-net@FreeBSD.ORG Subject: Re: Proposal for ethernet, bridging, netgraph Message-ID: <20000425105926.A518@waterspout.com> References: <3902A56B.167EB0E7@elischer.org> <200004250214.TAA30215@bubba.whistle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0.1i In-Reply-To: <200004250214.TAA30215@bubba.whistle.com>; from archie@whistle.com on Mon, Apr 24, 2000 at 07:14:44PM -0700 Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Mon, Apr 24, 2000 at 07:14:44PM -0700, Archie Cobbs wrote: > OK, here's a patch ready for review & test.. this patch does one > thing, which is move the calls to BPF and BRIDGE'ing out of each > Ethernet driver and into ether_input(). Why not also modify ether_input() to remove the Ethernet header when appropriate? Instead of the monkey business to add the Ethernet Header back on. There are a couple of places in ether_input() that do this already, and you're proposing another for passing the packet to bpf. I proposed this a few weeks ago, but never cleaned up my patch for submission. It would certainly prevent some of the kludges to deal with the Ethernet Header for things that want a peek at it, like VLANs. - Steve To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message