From owner-svn-src-all@freebsd.org Wed Sep 18 15:04:12 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E9681FFCAA; Wed, 18 Sep 2019 15:04:12 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46YNY80tppz4R5J; Wed, 18 Sep 2019 15:04:11 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pl1-x643.google.com with SMTP id 4so68969pld.10; Wed, 18 Sep 2019 08:04:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=MfbK6b4YtIVwe8D8fbxZ4jQBGB/OBUeNzbVqgVBEBFg=; b=ieaScacJuXxCgvMCi8rJ3t8qXjyV6and2P2bYEojiblX3IQxS6RE6zZCznqxZ/lN/1 q98etIidJgS9jX2aJeyEcqejgjmLQo6h0iiAMtrlVSU73nwcTNVsezqNvrOlX/SAYHi+ rhDrqG1sQ+UUI+Zuf6cQSTpJMXd26wUpypuotAVnNQSGm0w7hFreYvDV6q2LWE9v8B5U IIG2/BzAA/vqK0pQk4DwtGRiKfcmu9hyrsEzFYpe+kks7Ofk3qgep/rMONGjhsX3R8lM OGQ0GGlJEW5bBuTSKTAB9UEMOgI1AzMXlw+d/FS2MXrXdA9I/lnUvTKU5jajgQteDgo5 BFWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=MfbK6b4YtIVwe8D8fbxZ4jQBGB/OBUeNzbVqgVBEBFg=; b=EgM7PxDNEl5HxuyvrUw0hYL8dhU508gxlkiSRAw/e0zpl3rf66T/1efeWcq5P/Jhgm 3kFXdiUDf48AGIP7sX4eG9zUY3NHwOkepzgi1I6ed00gyRxa4KioAqhACv5aOhKCtaCE 5ao0Ackb57khvibMLe44h7pvF9oAThOdVXDfOT8iCY3JNZuXD4Gmmee9Cz0/R87eS7uU QLNs9qRkjfAtwNh7xTRqJE9bxZ2eDp2EL35YTwfGwyQxHq7mM7w/GXltb0dkefT58gM2 wjD1JBUdyZFqHxHiYt97RI/Tkg4ON1bS2xcGzwF4DNcKIKymEADgSgVrdtNcqVDzXObU X/Ag== X-Gm-Message-State: APjAAAWh550yF9uljZTvWEGNkt6GQFrXrt8dxUGHnZ8oXmcKtaxJkxTO HrGxdSj3FUja+dfDLjxuFw5AA/WLb8c= X-Google-Smtp-Source: APXvYqwlE0BD3sQvXNyH93tJMZJQZ1Q/VZhPnUvy+kVW0FtbhPy6pg3kKZcTVSxPMMaK/oiwdF/4rQ== X-Received: by 2002:a17:902:a411:: with SMTP id p17mr4654999plq.108.1568819049098; Wed, 18 Sep 2019 08:04:09 -0700 (PDT) Received: from ?IPv6:2607:fb90:8361:37e4:e838:8e5e:c58b:1a9d? ([2607:fb90:8361:37e4:e838:8e5e:c58b:1a9d]) by smtp.gmail.com with ESMTPSA id a8sm9174421pfa.182.2019.09.18.08.04.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Sep 2019 08:04:08 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r352465 - head/share/mk From: Enji Cooper X-Mailer: iPhone Mail (16G102) In-Reply-To: Date: Wed, 18 Sep 2019 08:04:07 -0700 Cc: src-committers , svn-src-all , svn-src-head Content-Transfer-Encoding: quoted-printable Message-Id: References: <201909180158.x8I1wuZu011258@repo.freebsd.org> <0FBC9A62-AE3B-4F27-AABC-06FF45F415F1@gmail.com> <81382CF5-A928-48EF-93A9-BBBBA174F4BD@gmail.com> To: Kyle Evans X-Rspamd-Queue-Id: 46YNY80tppz4R5J X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=ieaScacJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::643 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-2.50 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-0.56), ipnet: 2607:f8b0::/32(-2.68), asn: 15169(-2.23), country: US(-0.05)]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE_FREEMAIL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[3.4.6.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 15:04:13 -0000 > On Sep 18, 2019, at 07:58, Kyle Evans wrote: >=20 >> On Wed, Sep 18, 2019 at 9:46 AM Enji Cooper wrote= : >>=20 >>=20 >>> On Sep 18, 2019, at 07:33, Enji Cooper wrote: >>>=20 >>>=20 >>>>> On Sep 18, 2019, at 05:40, Kyle Evans wrote: >>>>>=20 >>>>> On Wed, Sep 18, 2019 at 7:34 AM Enji Cooper wr= ote: >>>>>=20 >>>>>=20 >>>>>> On Sep 17, 2019, at 18:58, Kyle Evans wrote: >>>>>>=20 >>>>>> Author: kevans >>>>>> Date: Wed Sep 18 01:58:56 2019 >>>>>> New Revision: 352465 >>>>>> URL: https://svnweb.freebsd.org/changeset/base/352465 >>>>>>=20 >>>>>> Log: >>>>>> googletest: default-disable on all of MIPS for now >>>>>>=20 >>>>>> Parts of the fusefs tests trigger a bug in current versions of llvm: I= R >>>>>> representation of some routine for the MIPS targets is a function wit= h a >>>>>> large number of arguments. This then leads the compiler on an hour+ l= ong >>>>>> goose chase, which is OK if you build the current tree but less-so if= you're >>>>>> trying external toolchain or doing a universe build involving mips wh= en it >>>>>> eventually gets switched over to LLVM. >>>>>>=20 >>>>>> Better, accurate details can be found in LLVM PR43263. >>>>>=20 >>>>> Uhhhhh... why not do this in tests/sys/... instead? >>>>=20 >>>> Because there's still value in being able to easily enable these for >>>> building/running the complete set of tests through standard build >>>> infrastructure, but it's not worth adding a knob specifically for the >>>> fusefs tests. I also prefer the communication of it being an >>>> off-by-default option and easily deduced from src.conf(5) that this >>>> part of the build is default-disabled on mips/mips. >>>=20 >>> Let me rephrase things a bit: is googlemock broken for all of mips, or i= s it just the tests? If the latter, the tests should be blacklisted for mips= with a justification. If the former, I agree your method of dealing with th= e situation is ok, but more investigation needs to be done to see whether or= not the port (in general) is broken and mark it broken if need be. >>=20 >> It looks like the latter case, based on the PR, and it=E2=80=99s a build p= erformance issue... Is this impacting CI pipelines? >>=20 >=20 > It is the latter, and I do not want to *blacklist* them because as far > as I can tell, the tests aren't necessarily broken. I want to > workaround them for default by now. >=20 >>> The problem with src.opts.mk=E2=80=99s per-architecture options, is that= it can be very heavy handed enabling/disabling features. I=E2=80=99m not su= re that everything in there warrants disabling at that level. >>=20 >> My investigation suggests that the course of action was overly heavy hand= ed. While I=E2=80=99m not asking for a revert, it would be really nice if wh= ole features weren=E2=80=99t disabled, unless there=E2=80=99s an issue with t= he feature. >>=20 >=20 > We do not have a lighter method for dealing with this that I can tell, > because as I said above: I do not want to blacklist them or completely > kill them off. I still want the option to build and test them, but as > I aim to switch mips over to llvm I do not want to subject CI and the > rest of the world to an extra 1.5+ hour build time for this during > tinderbox runs. >=20 > Given that it's mips, so already tier-high, and I'm one of few people > that care about it (and I only care about it for the time being), I > intend to leave it as-is since it's still a default in the rest of the > world. Ok, valid straw man argument: in this particular case, should llvm / c++ sup= port be disabled instead, since it=E2=80=99s the real underlying issue? I=E2= =80=99m guessing (non-ancient) g++ doesn=E2=80=99t have this issue. Again, disabling a framework because of a single issue in the tests doesn=E2= =80=99t make sense. Unless you have proof that the build times for all of go= ogletest/googlemock with llvm is an issue, this seems like the wrong remedia= tion to perform. -Enji PS A heads up to asomers and myself would have been nice. I don=E2=80=99t li= ke post-commit nitpicking, since the issue could have been discussed/reviewe= d before commit.=