From owner-p4-projects@FreeBSD.ORG  Sun Sep  3 21:01:58 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 82EDE16A4E1; Sun,  3 Sep 2006 21:01:58 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5D28916A4DD
	for <perforce@freebsd.org>; Sun,  3 Sep 2006 21:01:58 +0000 (UTC)
	(envelope-from jmg@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3EFA343D4C
	for <perforce@freebsd.org>; Sun,  3 Sep 2006 21:01:56 +0000 (GMT)
	(envelope-from jmg@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k83L1tka061293
	for <perforce@freebsd.org>; Sun, 3 Sep 2006 21:01:55 GMT
	(envelope-from jmg@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k83L1tIQ061290
	for perforce@freebsd.org; Sun, 3 Sep 2006 21:01:55 GMT
	(envelope-from jmg@freebsd.org)
Date: Sun, 3 Sep 2006 21:01:55 GMT
Message-Id: <200609032101.k83L1tIQ061290@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jmg@freebsd.org using -f
From: John-Mark Gurney <jmg@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 105615 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Sep 2006 21:01:58 -0000

http://perforce.freebsd.org/chv.cgi?CH=105615

Change 105615 by jmg@jmg_carbon-60 on 2006/09/03 21:01:05

	add a bit more debugging..

Affected files ...

.. //depot/projects/kmacy_sun4v_stable/src/sys/dev/ata/ata-all.c#3 edit
.. //depot/projects/kmacy_sun4v_stable/src/sys/dev/ata/ata-all.h#4 edit
.. //depot/projects/kmacy_sun4v_stable/src/sys/dev/ata/ata-queue.c#3 edit

Differences ...

==== //depot/projects/kmacy_sun4v_stable/src/sys/dev/ata/ata-all.c#3 (text+ko) ====

@@ -571,6 +571,7 @@
     u_int8_t command = 0;
     int error = ENOMEM, retries = 2;
 
+	device_printf(atadev->dev, "ata_getparam called\n");
     if (ch->devices &
 	(atadev->unit == ATA_MASTER ? ATA_ATA_MASTER : ATA_ATA_SLAVE))
 	command = ATA_ATA_IDENTIFY;
@@ -592,10 +593,12 @@
 	request->bytecount = sizeof(struct ata_params);
 	request->donecount = 0;
 	request->transfersize = DEV_BSIZE;
+	device_printf(atadev->dev, "ata_queue_request called\n");
 	ata_queue_request(request);
 	error = request->result;
 	ata_free_request(request);
     }
+	device_printf(atadev->dev, "ata_queue_request done\n");
 
     if (!error && (isprint(atadev->param.model[0]) ||
 		   isprint(atadev->param.model[1]))) {

==== //depot/projects/kmacy_sun4v_stable/src/sys/dev/ata/ata-all.h#4 (text+ko) ====

@@ -357,7 +357,7 @@
 };
 
 /* define this for debugging request processing */
-#if 0
+#if 1
 #define ATA_DEBUG_RQ(request, string) \
     { \
     if (request->flags & ATA_R_DEBUG) \

==== //depot/projects/kmacy_sun4v_stable/src/sys/dev/ata/ata-queue.c#3 (text+ko) ====

@@ -63,6 +63,7 @@
 	    (request->callback)(request);
 	return;
     }
+	device_printf(request->dev, "in ata_queue_request\n");
     ch = device_get_softc(request->parent);
     callout_init_mtx(&request->callout, &ch->state_mtx, CALLOUT_RETURNUNLOCKED);
     if (!request->callback && !(request->flags & ATA_R_REQUEUE))