From nobody Fri Jul 4 20:26:06 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bYlWz0jjYz60lK3; Fri, 04 Jul 2025 20:26:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bYlWy4W6Gz3syl; Fri, 04 Jul 2025 20:26:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751660766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yg2wSEJTYSuzKOmDTtTq/7wDTUJaOxh/g3Lz0VG3bfg=; b=Cw9CYb4K1Ft+rEDgG3mSzIBQevSVGdb/kNCY7iwWCB56/j95uuHDU16RKqy2csVpzX4XeN +JSclp4+VJrSfUvhMnjG4oNM8PdNV/hMDLTzwEJQ9wxCOaL0RtYXpI/yr+uqZLp6txn1nI QsxwBTUSxc7pAN0vgC3wgNEGBbFMWQ/coPkHLriJCYbdlMBB/2i3QEkac0QIqSkRHP9w4m 2gQqWIAHj3pIlCw1d+rGhW5PkdGHlMJCHqqaHZqmJIjRm1KNLe3mIZv3ENqboGKzLmzsAo jvgb38t3YukTzGf9HKoja30VKhE0EZT4UNjotR1cOYFSRkWvFPtSGw/RudFNBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751660766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yg2wSEJTYSuzKOmDTtTq/7wDTUJaOxh/g3Lz0VG3bfg=; b=bBemKZ1utVk+8ExXd2kg2aN5sM2UhoKTzW0D3vE8ThgiqU/Sec2uj9ZibLMsgZRQAoiDeM sr8cmgzhIAxR6woZpAJ2YYAQ1fHJH03WA+5Xm433d1EBhW8h4lkI8O7tQ9u7FwRYFIhayq LIIqTHPb79A8U9/76Mq2ac9mx9UKu49PSP0nRQciPq5oj4iPSJ0yR9DgRappFYeX5knr/C /wK2DpEOD6uLp9hdcaG9Be6CcrhZe6HO7cuR3HOznC83npNy0GVB0eeSfuYK+zj2tvylqx MVRlMU4oKLM/a/fjiYMBYngTgifd2xM/HsghsX+SlpOP+MQmYP7Ue6rE+wX5zQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751660766; a=rsa-sha256; cv=none; b=vcz+GMb/X0kFa4Xzu0I6riLmekOZvmC5qERmSqBZ/ofPsPxsLB00hVNhTYqx3BNMvUm85D LTRgkvXKxFGVk5bD7Vq/t+ikfvtze+ebMOaA2ZPeqIGdAn1gm9AhLM514hjOsqlSrsfxHk lADw05d5cVBBlQ55mBxCAWHJpWB2MjUypW7Bdce7Ycylix7x7dGZCbTS7ABPPiZSa0vdMk Z2aaJyj9HnusiG/fGp+4WusFDHzOj10MQEOBftIajlitbODTmq8h57/vhyIda1XWvdmF3Z t35OpiABSQA1NzQCkWrCbq0af8HiVDj9Lf8XXJLEOG0gvVdkjFMpbHZqmnvDEA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bYlWy3pqSz14Qn; Fri, 04 Jul 2025 20:26:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 564KQ6gG096763; Fri, 4 Jul 2025 20:26:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 564KQ61o096760; Fri, 4 Jul 2025 20:26:06 GMT (envelope-from git) Date: Fri, 4 Jul 2025 20:26:06 GMT Message-Id: <202507042026.564KQ61o096760@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ahmad Khalifa Subject: git: ed50879c4a95 - main - gpiobus: gpiobus_acquire_pin: panic on invalid pin List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ed50879c4a9591d075890f61c7f8f7c29d5c6f3a Auto-Submitted: auto-generated The branch main has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=ed50879c4a9591d075890f61c7f8f7c29d5c6f3a commit ed50879c4a9591d075890f61c7f8f7c29d5c6f3a Author: Ahmad Khalifa AuthorDate: 2025-06-19 13:42:56 +0000 Commit: Ahmad Khalifa CommitDate: 2025-07-04 20:24:31 +0000 gpiobus: gpiobus_acquire_pin: panic on invalid pin It is a programming error to call this function with an invalid pin. Also return proper error value on failure. Suggested by: mmel Reviewed by: imp, mmel Approved by: imp (mentor) Differential Revision: https://reviews.freebsd.org/D50940 --- sys/dev/gpio/gpiobus.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sys/dev/gpio/gpiobus.c b/sys/dev/gpio/gpiobus.c index 6b5379b6084a..ab849ca3db98 100644 --- a/sys/dev/gpio/gpiobus.c +++ b/sys/dev/gpio/gpiobus.c @@ -401,14 +401,13 @@ gpiobus_acquire_pin(device_t bus, uint32_t pin) sc = device_get_softc(bus); /* Consistency check. */ if (pin >= sc->sc_npins) { - device_printf(bus, - "invalid pin %d, max: %d\n", pin, sc->sc_npins - 1); - return (-1); + panic("%s: invalid pin %d, max: %d", + device_get_nameunit(bus), pin, sc->sc_npins - 1); } /* Mark pin as mapped and give warning if it's already mapped. */ if (sc->sc_pins[pin].mapped) { device_printf(bus, "warning: pin %d is already mapped\n", pin); - return (-1); + return (EBUSY); } sc->sc_pins[pin].mapped = 1;