From owner-cvs-all Wed Feb 12 11:19:12 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 609B737B407; Wed, 12 Feb 2003 11:19:10 -0800 (PST) Received: from mta6.snfc21.pbi.net (mta6.snfc21.pbi.net [206.13.28.240]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA6BC43F3F; Wed, 12 Feb 2003 11:19:09 -0800 (PST) (envelope-from hsu@FreeBSD.org) Received: from FreeBSD.org ([63.193.112.125]) by mta6.snfc21.pbi.net (iPlanet Messaging Server 5.1 HotFix 1.6 (built Oct 18 2002)) with ESMTP id <0HA700J3GMX8MM@mta6.snfc21.pbi.net>; Wed, 12 Feb 2003 11:17:32 -0800 (PST) Date: Wed, 12 Feb 2003 11:20:31 -0800 From: Jeffrey Hsu Subject: Re: cvs commit: src/sys/netinet tcp_syncache.c In-reply-to: Message from Guido van Rooij "of Wed, 12 Feb 2003 14:00:57 +0100." <20030212130057.GA27427@gvr.gvr.org> To: Guido van Rooij Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-id: <0HA700J3HMX8MM@mta6.snfc21.pbi.net> MIME-version: 1.0 X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > On Tue, Feb 11, 2003 at 04:42:12PM -0800, Jeffrey Hsu wrote: > > hsu 2003/02/11 16:42:12 PST > > > > Modified files: > > sys/netinet tcp_syncache.c > > Log: > > Properly document that syncache timer processing requires an > > exclusive TCP protocol lock. > > This seems like a strange way of telling us you need a write-lock instead > of a read lock... > > -Guido A write lock is an exclusive lock. (A read lock is a shared lock.) Since INP_INFO_RLOCK() and INP_INFO_WLOCK() are both currently defined to be the same mutex lock, this commit doesn't change anything other than documenting for future reference when shared access can occur and when exclusive access is required. Jeffrey To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message