From owner-freebsd-net@FreeBSD.ORG Wed Mar 31 17:14:26 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DC3381065676; Wed, 31 Mar 2010 17:14:26 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from mail-bw0-f216.google.com (mail-bw0-f216.google.com [209.85.218.216]) by mx1.freebsd.org (Postfix) with ESMTP id 35D6A8FC15; Wed, 31 Mar 2010 17:14:25 +0000 (UTC) Received: by bwz8 with SMTP id 8so256787bwz.3 for ; Wed, 31 Mar 2010 10:14:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:subject:mime-version :content-type:from:in-reply-to:date:cc:content-transfer-encoding :message-id:references:to:x-mailer; bh=4rGG3EYVCI1mRBvySpgYt/yAdKeLHdak+nq2eyQxhf4=; b=LT/J4Jf3u6HLqalaRvrMH8sEKGmDwHTVUhuNLqaHSNNOuvpEtl0Hr/HDOmb6lKDE6P V5Umw0/8J0bZ3SHEJq+xrEknNMxYsQ9M5QNemqE2GGmSK+A4ODFSN1HcUjXYJkPZO2hc iQ4BIuOeWbEu79NW1Vdz5HBbJElM6hoHwu4x4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; b=qvHbng5HSG1wzErF8Ldj5/vdCWby2Dzg0Pnd5eJCXrkevfF/n4l0HVWrzh8mruPItB 6ruCS79WR6nmS8ez+7u+qQ+B4WGjml+YlNuOGgcIr0Kwn28PVng96XsB/FYmk/EykL4B 4SMPF9HZE6qp6aOfsoBfQWJa04daPH3KeIFs0= Received: by 10.204.132.194 with SMTP id c2mr771271bkt.167.1270055664741; Wed, 31 Mar 2010 10:14:24 -0700 (PDT) Received: from [10.0.10.2] (54.81.54.77.rev.vodafone.pt [77.54.81.54]) by mx.google.com with ESMTPS id s17sm59149530bkd.16.2010.03.31.10.14.22 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 31 Mar 2010 10:14:23 -0700 (PDT) Sender: Rui Paulo Mime-Version: 1.0 (Apple Message framework v1078) Content-Type: text/plain; charset=us-ascii From: Rui Paulo In-Reply-To: <20100331170648.GB6121@mx.techwires.net> Date: Wed, 31 Mar 2010 18:14:21 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <63B143BF-20C9-425F-8969-B7452191E84F@freebsd.org> <20100331140415.GB68231@mx.techwires.net> <47F572EE-B5E5-4961-81C5-179AD0F4A90A@freebsd.org> <20100331170648.GB6121@mx.techwires.net> To: Bernhard Schmidt X-Mailer: Apple Mail (2.1078) Cc: freebsd-net , Antoine Brodin Subject: Re: net80211 ratectl proof of concept X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2010 17:14:26 -0000 On 31 Mar 2010, at 18:06, Bernhard Schmidt wrote: > On Wed, Mar 31, 2010 at 03:05:27PM +0100, Rui Paulo wrote: >> On 31 Mar 2010, at 15:04, Bernhard Schmidt wrote: >>=20 >>> On Wed, Mar 31, 2010 at 02:31:30PM +0100, Rui Paulo wrote: >>>> On 31 Mar 2010, at 14:24, Antoine Brodin wrote: >>>>> This looks great! >>>>> Is there specific reasons to use pointers and not ints for some >>>>> arguments of foo_tx_complete() and foo_tx_update()? >>>>=20 >>>> Not really. I'll probably switch them to ints at some point. >>>=20 >>> Hmm, I somehow like the idea of not passing integers here. Looking = at >>> ath_rate/sample it passes a struct. I don't know whether this can be >>> rewritten though. >>=20 >> It can be rewritten to pass ints, from what I understand. >=20 > Ok great, looks fine to me. >=20 > Do you intend to commit this in one huge chunk (quite a few drivers > affected) or create a branch for that? I wanted people to comment on the general framework. I wasn't planning on creating a branch, because I didn't feel it was = necessary. Porting AMRR code to this framework isn't hard and I can deal = with any fallout. -- Rui Paulo