From owner-svn-src-head@freebsd.org Sat Nov 14 20:50:39 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3047246554D for ; Sat, 14 Nov 2020 20:50:39 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CYSCf6jwPz3wPn for ; Sat, 14 Nov 2020 20:50:38 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qt1-x82e.google.com with SMTP id z3so6323476qtw.9 for ; Sat, 14 Nov 2020 12:50:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Kkcn/Hpq9tGhRPJZx/mASkhxRH/Q+4wQ2Ut0a7dH6TY=; b=QvJu5QFD7fTBHl1yT1gaxEERid2ElXzIO9dVYYC1ftYiXr0w2HOTI0+Vmo/kZgpPKq rppsRPf8KKWT+lpu5r9OV9Uq7sF8Sn4o1J14o6oUxMRvp/xFkqYH/ExnZmZqvopR7K6Y vuHnE+RmiSLulRyi5xusglUkc/Kz7dDMGm0/wKUDspLBWfP6VfDzXx8UO4h35wfD1ebp +5lSkFWK71eBB1073RxqiqpdXa2DlJuPN9zX8JWUrmLCL81LZuZFEqxJfn8Z5ZoxJVtc ufvRI6pHZWm5o8yOKqXkkpXwjwnhW5o+fOYGFKkHhDofbbxFlWlezgUvWVkfw5Mj+QAm HdMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Kkcn/Hpq9tGhRPJZx/mASkhxRH/Q+4wQ2Ut0a7dH6TY=; b=lU5Woj9e7Taw4BdC5IhL0mE8e1hQv8IDJjg59J92rYcy33vhNaXlsASulyD7lCtM3m CWGKOVc/Jo0AFuMR1/U8Yf34ih2XLzyZ+TyW2CNEN4lDF4UVyDU8uNFgm9y3dpngd+b4 UKqxkGY18f5J/jHgsP/oYZPgj81dZC2S8dwnuAGdfKDruzruGjGG+rWULy4IJIB4cuso pNcKEvYvHNHicwwGOeR2jNfkg4nMrWkZugu0zBhZqIW3O//LJ4VbtvvT3V4D79laf0Q1 g87i0UXArOso2qic04Mxuohpq6hwbI1iPizvLa7nZO/yeYhK+jtJxtl4bpTZz3N8WuO8 YXTQ== X-Gm-Message-State: AOAM533DmmNIGMN4dvs3h7HuIePWIIUxFPnfjlNQveFvPvwXfbch3R3f PDsijZ2MQwG5t8JQ2tq+uhktxzdVmbgR37Vr X-Google-Smtp-Source: ABdhPJzwotN/Qllc6Prb6VsblnK0Z7pb4CtaZRL1eJnbuSHbExCkgj2xdCMk4r5xxYK9I0n38VPTWA== X-Received: by 2002:a05:622a:50:: with SMTP id y16mr7899007qtw.119.1605387037919; Sat, 14 Nov 2020 12:50:37 -0800 (PST) Received: from mutt-hbsd (pool-100-16-222-53.bltmmd.fios.verizon.net. [100.16.222.53]) by smtp.gmail.com with ESMTPSA id z16sm9988581qka.18.2020.11.14.12.50.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Nov 2020 12:50:37 -0800 (PST) Date: Sat, 14 Nov 2020 15:50:36 -0500 From: Shawn Webb To: Mateusz Guzik Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r367692 - head/sys/sys Message-ID: <20201114205036.tnxvwarsddmu4shz@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 13.0-CURRENT-HBSD FreeBSD 13.0-CURRENT-HBSD X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0xFF2E67A277F8E1FA References: <202011141920.0AEJKbpO050396@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6hglt7f3pnphonso" Content-Disposition: inline In-Reply-To: <202011141920.0AEJKbpO050396@repo.freebsd.org> X-Rspamd-Queue-Id: 4CYSCf6jwPz3wPn X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Nov 2020 20:50:39 -0000 --6hglt7f3pnphonso Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 14, 2020 at 07:20:37PM +0000, Mateusz Guzik wrote: > Author: mjg > Date: Sat Nov 14 19:20:37 2020 > New Revision: 367692 > URL: https://svnweb.freebsd.org/changeset/base/367692 >=20 > Log: > cred: reorder cr_audit to be closer to the lock > =20 > This makes cr_uid avoid sharing. >=20 > Modified: > head/sys/sys/ucred.h >=20 > Modified: head/sys/sys/ucred.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/sys/ucred.h Sat Nov 14 19:19:27 2020 (r367691) > +++ head/sys/sys/ucred.h Sat Nov 14 19:20:37 2020 (r367692) > @@ -63,6 +63,7 @@ struct ucred { > struct mtx cr_mtx; > u_int cr_ref; /* (c) reference count */ > u_int cr_users; /* (c) proc + thread using this cred */ > + struct auditinfo_addr cr_audit; /* Audit properties. */ > #define cr_startcopy cr_uid > uid_t cr_uid; /* effective user id */ > uid_t cr_ruid; /* real user id */ > @@ -78,7 +79,6 @@ struct ucred { > void *cr_pspare2[2]; /* general use 2 */ > #define cr_endcopy cr_label > struct label *cr_label; /* MAC label */ > - struct auditinfo_addr cr_audit; /* Audit properties. */ > gid_t *cr_groups; /* groups */ > int cr_agroups; /* Available groups */ > gid_t cr_smallgroups[XU_NGROUPS]; /* storage for small groups */ Hey Mateusz, Since this changes KBI, does __FreeBSD_version need bumping? Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 https://git-01.md.hardenedbsd.org/HardenedBSD/pubkeys/src/branch/master/Sha= wn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --6hglt7f3pnphonso Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAl+wQxkACgkQ/y5nonf4 4fqmvw/+LqkXst4/4+Gu+hoTF4T05ao+JGmx/RG6xHteFNhIYR2Y63VSscIv+kHT 8tSus5N6WrSgdaN2nwxpv/dYxR6Z8CEM+5OjFEwoEqaWugu6rWxLAyhDrPkNkKvT bka4vAvZPiHxfQqwWuE7aMoWd+4O9LFl8WSLc7zLIe9rQsjr2E5woHldG8u/mheF tw1kle1JK8hIzy5Qfi62FUvEtIhpI4Vo60wXeUV8iXnUHUEC6L4umeY447blLkKp kqyvP7BUjMB5bgZVvNpzgKQ+Lx3zDpl1SVcJznN069OQm1xzGs+Ob5gam75eG5at BqzJRB0cD0snH5dQBqhiij3cd4L8/B5p/OK+klqEgOWfIryDVH0C1uiH0eXzZPZR 9Zawk5hIV2LevbHzuWiM/Fg98dpyOEjvRPc5bs7L1w5mqC5l7X3lzZEXOeaUa/HW ZJoje5ocYEST1wlDkrJ8JFw/rTrNxDA7Rm/5kPTZv8sBzhXNC+1ZELUf129BUktc jNcmxwdqlt/CAU2vuz49A+R0yOESEY50gy6K3GDai/gF+jKNJ0DLUlvdLsWUT4zm Zmn98N3cNVPSPkHKXJbJVxr3bamYRK23w2S/NFuxMWug1R4oYNs4oimSFxL69bXF /Y2XdCX92S7N8EiepAGG0j3QdMCJZUhKi/fXU6CdMtkzJhyMv2I= =zV3q -----END PGP SIGNATURE----- --6hglt7f3pnphonso--