From owner-cvs-all Tue Apr 2 23:56:59 2002 Delivered-To: cvs-all@freebsd.org Received: from mail.nsu.ru (mx.nsu.ru [193.124.215.71]) by hub.freebsd.org (Postfix) with ESMTP id 5CA5137B41C; Tue, 2 Apr 2002 23:56:47 -0800 (PST) Received: from regency.nsu.ru ([193.124.210.26]) by mail.nsu.ru with esmtp (Exim 3.20 #1) id 16sfcZ-0004z5-00; Wed, 03 Apr 2002 14:55:55 +0700 Received: (from danfe@localhost) by regency.nsu.ru (8.11.6/8.11.6) id g337uKG33449; Wed, 3 Apr 2002 14:56:20 +0700 (NOVST) (envelope-from danfe) Date: Wed, 3 Apr 2002 14:56:19 +0700 From: Alexey Dokuchaev To: Julian Elischer Cc: Kenneth Culver , Mike Barcroft , Matthew Dillon , "M. Warner Losh" , jake@locore.ca, dillon@freebsd.org, cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/i386 critical.c src/sys/i386/include cpufunc.h critical.h src/sys/i386/isa apic_vector.s icu_vector.s src/sys/kern kern_fork.c kern_proc.c kern_switch.c src/sys/alpha/alph Message-ID: <20020403145619.A31477@regency.nsu.ru> References: <20020402100957.C45652-100000@alpha.yumyumyum.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from julian@elischer.org on Tue, Apr 02, 2002 at 11:22:53AM -0800 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Apr 02, 2002 at 11:22:53AM -0800, Julian Elischer wrote: > > > On Tue, 2 Apr 2002, Kenneth Culver wrote: > > > > > if (a) { > > > > x; > > > > y; > > > > } else > > > > /* > > > > * HITHERE! > > > > */ > > > > b; > > > > > > This looks better with proper 8 character tabs. I think in KNF extra > > > braces are normally used in situations like this, but this is an edge > > > case. > > > > 8 character tabs? why use tabs at all? That requires an > > engineer/programmer to set that in an editor, and a lot of people don't > > like having tabs that are that large... I just use spaces because then my > > code will look the same as when I wrote it no matter what editor is used, > > and no matter what the tabs are set to. > > Then your code would be different from all other code in FreeBSD. > Code checeked in should be 8 character tabs.. this is one of the most > BASIC requirements, even if some developers feel themselves too important > to abide by it.. It is one of the first things that gives the BSD > code base a unified appearance. I totally agree: from what I've seen, faaaar most of BSD code looks so unified (read: neat and appealing), contrary to Linux' one, for instance ;-) Methinks it's very inappropriate to destroy that style(9) tradition of years... ./danfe To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message