Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 27 Feb 2020 23:06:13 +0000 (UTC)
From:      Jung-uk Kim <jkim@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r358413 - head/contrib/sendmail/src
Message-ID:  <202002272306.01RN6Dg7067128@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jkim
Date: Thu Feb 27 23:06:12 2020
New Revision: 358413
URL: https://svnweb.freebsd.org/changeset/base/358413

Log:
  Plug possible memory leaks in the previous patch.
  
  Two DH_free() calls were accidentally removed.
  
  Pointyhat to:	jkim

Modified:
  head/contrib/sendmail/src/tls.c

Modified: head/contrib/sendmail/src/tls.c
==============================================================================
--- head/contrib/sendmail/src/tls.c	Thu Feb 27 22:36:16 2020	(r358412)
+++ head/contrib/sendmail/src/tls.c	Thu Feb 27 23:06:12 2020	(r358413)
@@ -92,6 +92,7 @@ get_dh512()
 	dhg_bn = BN_bin2bn(dh512_g, sizeof(dh512_g), NULL);
 	if ((dhp_bn == NULL) || (dhg_bn == NULL))
 	{
+		DH_free(dh);
 		BN_free(dhp_bn);
 		BN_free(dhg_bn);
 		return NULL;
@@ -155,6 +156,7 @@ get_dh2048()
 	dhg_bn = BN_bin2bn(dh2048_g, sizeof(dh2048_g), NULL);
 	if ((dhp_bn == NULL) || (dhg_bn == NULL))
 	{
+		DH_free(dh);
 		BN_free(dhp_bn);
 		BN_free(dhg_bn);
 		return NULL;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202002272306.01RN6Dg7067128>