From owner-svn-src-all@freebsd.org Tue Feb 21 07:12:46 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1C048CE7806; Tue, 21 Feb 2017 07:12:46 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 8E4EDB05; Tue, 21 Feb 2017 07:12:40 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id JAA22314; Tue, 21 Feb 2017 09:12:38 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1cg4co-000M8h-Ei; Tue, 21 Feb 2017 09:12:38 +0200 Subject: Re: svn commit: r313878 - head/sys/kern To: Pedro Giffuni , Bryan Drewery , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org References: <201702171540.v1HFeOAs074991@repo.freebsd.org> <7da9caa5-d938-d2d0-1228-0e8897dc5632@FreeBSD.org> From: Andriy Gapon Message-ID: <56ca9623-dc6f-41fc-ba81-e7486a4ba8e3@FreeBSD.org> Date: Tue, 21 Feb 2017 09:11:42 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <7da9caa5-d938-d2d0-1228-0e8897dc5632@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Feb 2017 07:12:46 -0000 On 21/02/2017 02:42, Pedro Giffuni wrote: > FWIW, > > > On 2/20/2017 7:24 PM, Bryan Drewery wrote: >> On 2/17/2017 7:40 AM, Mateusz Guzik wrote: >>> Author: mjg >>> Date: Fri Feb 17 15:40:24 2017 >>> New Revision: 313878 >>> URL: https://svnweb.freebsd.org/changeset/base/313878 >>> >>> Log: >>> mtx: get rid of file/line args from slow paths if they are unused >>> This denotes changes which went in by accident in r313877. >> I really wish people would just revert their changes and recommit them >> properly. The 'svn blame' on the code in r313877 will never show the >> commit message here (r313878). So a person would only find this >> explanation if they read 'svn log' on the file, which in the case of >> sys/kern/kern_mutex.c there are 273 commits for. Are we expected to >> read 'svn log' (in the future) for all changes in the hopes that a later >> commit happens to mention it? >> >> As someone who so often is 'svn blame'ing code to understand it better >> and to track regressions, commits like this that explain other commits >> might as well have never been done. > > As I mentioned in another thread, other svn configurations (ASF, for example) > permit editing the log message: > > http://help.collab.net/index.jsp?topic=/faq/changelog.html How well do various svn exporters handle that? Specifically, svn-> git ? -- Andriy Gapon