From nobody Thu Jul 24 22:44:11 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bp5f650Y3z63Fhn; Thu, 24 Jul 2025 22:44:14 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bp5f64919z42sl; Thu, 24 Jul 2025 22:44:14 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753397054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rkyW8LBA+OhGePxrJadWXjqF0IL/z5urMR7wLxusYfg=; b=sLZpxagBKMJF2VtEMTdriBZ73yv2FP74fI7+axELPuKFAtOBTVkqr7yE9WQBKr4/O8ZJBC sRfy164przOK4dADj3+dkekCErKTZnpdsjXAdIoriiL5+BVMgKTTI6LoxRm7EPrM1I66b3 +sfgG2AE7I+/2EEWqt1TNOH9p6C/qCb3TF4DNT78lFF8Vjfbz8azCme81OzsRgyCwrvuMm zN74fqoOjWw+J4rRvLNwak6R3ts/dN8DQRarycsPXHBcb4RljIZT82mx2Lmws6dwO+S0bu sWUiey1pc+TI+70NXWsVYeieQ9cVRXNquszRoyUAk80O1ffI3kXmXxy92AUDtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753397054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rkyW8LBA+OhGePxrJadWXjqF0IL/z5urMR7wLxusYfg=; b=Bkw9Yv3tuoDE8EbeAvOdg2F31o/H3Od0cbACIc1MhOquYujh+olT2ALCgZPSMkb64RfuWc gkiodQR1sk8hDrYHRJH5IE0yOLx7/hpFhc2Ga6TWs3ikHMLMNk4jpSeyOaSDh8YdhyYQRC 0OLXXAWDd5/A8BGWK/gytlA5mAkaJpOfHqZJMxA8SjlJJza/Glku3Pr5mkG5oH2QffllGD YraH9M91UR0mOvpWpCa845gR5mj3yjjF3nWoKcTLCzW7pE1WXwc0oGuh8oSqJdilHp5LJ+ ZY4RvJqgjcoiLauhSH9nxKyTyOVKQKbweRDS7evyswWlCxm+u+8qrHxvV3Yv0Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1753397054; a=rsa-sha256; cv=none; b=hWIIj3/DVbwvLw6N7gaSgf6ZP7RRtISMXF00Rptuf6TQzEeVMb23uoqxCkavSJJOZ56ZCm 8cXddZoarLCafwBYbzZ9nYaLuM2b+PK0Pxr4QQVfkg/fbDKQWhyrh1HT1XltBCf2764nsx XFQcJQrsRfPm8zITnYuKTOWEZrCMBXNqT9PjTrUEEUk2/MPCg+MLUCIlr+R2S9FY6ZhJPv DZRyad6a1T/LozH3eNYnZITdwRu7tmvggOtiklOJcro2qxOrXB0oSPjkCb/O0/QJuuHDSv 3hffY05gvK0z//TF8iuKmVZtE6xfX/n9ruMLzresi3XKje69a7l4NluKYjlAyQ== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bp5f56WdVz1DlR; Thu, 24 Jul 2025 22:44:13 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Thu, 24 Jul 2025 15:44:11 -0700 From: Gleb Smirnoff To: Kristof Provost Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4bb3b3657764 - main - pf: unify DPFPRINTF definitions Message-ID: References: <202507231423.56NENthc031396@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202507231423.56NENthc031396@gitrepo.freebsd.org> On Wed, Jul 23, 2025 at 02:23:55PM +0000, Kristof Provost wrote: K> commit 4bb3b365776458bd8f710e40f97e2c68994e3306 K> Author: Kristof Provost K> AuthorDate: 2025-07-18 14:55:35 +0000 K> K> pf: unify DPFPRINTF definitions K> K> We define DPFPRINTF() in a few different versions in most pf source files. K> Move to one definition in pfvar.h and use that one everywhere. K> K> While here change it to add an endline, as OpenBSD does, so we consistently end K> all logs with an endline. K> Also add a static probe point to ease future debugging. This way we can detect K> log evens even when logging is disabled, and extract more information (e.g. K> stack traces, frequency, ...). Thanks a lot! Every time I was debugging something in pf, I was missing those SDTs. -- Gleb Smirnoff