From owner-svn-src-all@FreeBSD.ORG Sat Feb 5 12:09:00 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1BD711065673; Sat, 5 Feb 2011 12:09:00 +0000 (UTC) (envelope-from peterjeremy@acm.org) Received: from mail11.syd.optusnet.com.au (mail11.syd.optusnet.com.au [211.29.132.192]) by mx1.freebsd.org (Postfix) with ESMTP id 8889A8FC0C; Sat, 5 Feb 2011 12:08:59 +0000 (UTC) Received: from server.vk2pj.dyndns.org (c220-239-52-50.belrs4.nsw.optusnet.com.au [220.239.52.50]) by mail11.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id p15C8ofh012662 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 5 Feb 2011 23:08:51 +1100 X-Bogosity: Ham, spamicity=0.000000 Received: from server.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by server.vk2pj.dyndns.org (8.14.4/8.14.4) with ESMTP id p15C0mHF021583; Sat, 5 Feb 2011 23:00:48 +1100 (EST) (envelope-from peter@server.vk2pj.dyndns.org) Received: (from peter@localhost) by server.vk2pj.dyndns.org (8.14.4/8.14.4/Submit) id p15C0mIB021582; Sat, 5 Feb 2011 23:00:48 +1100 (EST) (envelope-from peter) Date: Sat, 5 Feb 2011 23:00:48 +1100 From: Peter Jeremy To: Warner Losh Message-ID: <20110205120047.GE20095@server.vk2pj.dyndns.org> References: <201102032026.p13KQQX2057419@svn.freebsd.org> <20110203230721.GA47981@muon.cran.org.uk> <4D4C27E5.2020708@bsdimp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Lb0e7rgc7IsuDeGj" Content-Disposition: inline In-Reply-To: <4D4C27E5.2020708@bsdimp.com> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.20 (2009-06-14) Cc: svn-src-head@FreeBSD.org, Adrian Chadd , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r218238 - head/sys/dev/ath X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Feb 2011 12:09:00 -0000 --Lb0e7rgc7IsuDeGj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2011-Feb-04 09:23:01 -0700, Warner Losh wrote: >On 02/03/2011 16:07, Bruce Cran wrote: >> On Thu, Feb 03, 2011 at 08:26:26PM +0000, Adrian Chadd wrote: >>> if (ni !=3D NULL) { >>> +#if NOTYET >>> /* tag AMPDU aggregates for reorder processing */ >> This seems to have broken the build because NOTYET isn't defined. > >ANSI C states that all undefined preprocessor variables shall expand to=20 >0. If we have a warning on that complains, we should turn it off. Well, bde@ considers it a style bug so from that point of view, the warning is useful. Also, given that the normal way of stating that is "#ifdef NOTYET", keeping the warning may help catch code where the preprocessor variable was supposed to have been defined but has been misspelt - consider "#if _FreeBSD_version > 800100". --=20 Peter Jeremy --Lb0e7rgc7IsuDeGj Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (FreeBSD) iEYEARECAAYFAk1NO+8ACgkQ/opHv/APuIcR/QCeJmAdOeV8kG2u+bTgTkiBESGm jPQAoJ9RGexE1HSVesXs4OYdkzZKfTSe =aTK9 -----END PGP SIGNATURE----- --Lb0e7rgc7IsuDeGj--