From nobody Tue Sep 30 17:51:05 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cblwY6CBJz68y4H; Tue, 30 Sep 2025 17:51:09 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cblwY3CQSz3Hsj; Tue, 30 Sep 2025 17:51:09 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759254669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l2Y8ZWRbnK7NLklDc/+r0qpFp6Y4oUEaUF4RdUgm6oI=; b=ReI5bH7ETSyu4F0L9tbFr3lIFuQShmQHrkvCJy7lTOFTAFS0D7voF8j8SS9/WloTFgFPkv YIcqk6lzwWn6DFBIotk8modACVJYj+qDXR0iWkvF/QFXuXPJOZ8wXxOuMUkr+JPGz0aVH8 8N0BPblemJXMiLGfUBPKIZGg/Nq/J6k2OXgJ75VjxGobaxTzsRBDriWx+3C7ECndcoZeun rLuxlzRF49DuStTxzzDgCafwf67oTdZ8xBp4fYrDy3Vk9emnBssc9bKbDtOwrp26bzdbX/ +NWKTbwYwWQZEFpTnlt2pB6hoJawIjNIT4EmnL5GJxj10JrZm5/7gi0Iu86KXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759254669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l2Y8ZWRbnK7NLklDc/+r0qpFp6Y4oUEaUF4RdUgm6oI=; b=h5SeBUe/NXbjKPVGsB7YID2MMzMs8KxyFMpapawOQBAteuVlo0WN0HdGLgFP+RPRcx1znS WroL91ue+DPuW5iN7kOOXeJbq7XGrg9YGLyKS6vy9K+9Iw4GNnsJL7kKWCRCYrBFE61iYS xmfCSM8B3vnZxIrGOfdfichsU7UjvdCXN9kGav5sSF+Tl/SgCX5TcGSzw3zxKy/RMGrF3Q MyyFi1MQox6K/UfIdFue1spVKnss3SmcAdIT57UbCtOU3Sfm5F0yOUVeYUSClYPH+U5miT MovC/m+ZFZUBh90aiM8kxZCg4JWMn3YUd/BbHP9JAyA2ZIaa2xZMkxLkJFRtGw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759254669; a=rsa-sha256; cv=none; b=KE33LomXux6qWy8fWFkFeLpVrUguns5+iPrSVzGUVt/d/39rBSocGBb4PT+WNNjQwRsWLa i+Om88KuKjzS6bOqj0SV/PPtXzkqMkLm9Y5fAOlv2ro9Cm2LmZdGWiS3ipCSWm9FiVN4DR wjUgRxWVAP3RT2+U9/URmepWgOlYMYpybrRFOR1546OsZh8K6+PGmHPmJ9hcfe5iq/Zy2v riIPGfxP0d8jbeYy1A61i8VrR95AmjWc67D2U46M6HTO5U0mSQYexVhqSWNVK7b78xxp18 EJwANYAqHfms9TVO1ocP2TmBdYBawmywBscZWISC9zjEZ1HeecNcnchkSeB+ag== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R11" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cblwY1nSHz10lT; Tue, 30 Sep 2025 17:51:09 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id AC1DF80E0; Tue, 30 Sep 2025 19:51:06 +0200 (CEST) From: Kristof Provost To: Gleb Smirnoff Cc: ItzBlinkzy , Kevin Irabor , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4e7a375804e5 - main - IfAPI: Added missing accessor for if_home_vnet Date: Tue, 30 Sep 2025 19:51:05 +0200 X-Mailer: MailMate (2.0r6272) Message-ID: <9E63C594-08DD-43CD-BD76-3E9B9E80AA60@FreeBSD.org> In-Reply-To: References: <202509292116.58TLGxWx078766@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; markup=markdown Content-Transfer-Encoding: quoted-printable On 30 Sep 2025, at 19:39, Gleb Smirnoff wrote: > On Mon, Sep 29, 2025 at 09:16:59PM +0000, Kristof Provost wrote: > K> URL: https://cgit.FreeBSD.org/src/commit/?id=3D4e7a375804e5ad4b244ce= 9a035fa971cbf2f0944 > K> > K> commit 4e7a375804e5ad4b244ce9a035fa971cbf2f0944 > K> Author: ItzBlinkzy > K> AuthorDate: 2025-09-28 17:21:41 +0000 > K> Commit: Kristof Provost > K> CommitDate: 2025-09-29 21:15:55 +0000 > K> > K> IfAPI: Added missing accessor for if_home_vnet > K> > K> Reviewed by: kp > K> Signed-off-by: Kevin Irabor > > So, who is the actual author of the patch kitey13579@gmail.com or > ? > I=E2=80=99d assume they=E2=80=99re the same person, but yeah, it=E2=80=99= s not ideal. I pulled this from GitHub and missed the discrepancy. > The actual question is whether there is a driver that really needs to a= ccess > this field or was this added by the logic that if a field exists in str= uct > ifnet, a function to access it shall exist? > It=E2=80=99s hard to predict what fields will be relevant for out-of-tree= consumers, but it seems reasonable to allow access to this one given we = already allow the current vnet to be accessed too. Best regards, Kristof