From owner-freebsd-fs@FreeBSD.ORG Tue Sep 4 02:18:06 2012 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C4024106566C for ; Tue, 4 Sep 2012 02:18:06 +0000 (UTC) (envelope-from ian@ianshome.com) Received: from smtp2.woosh.co.nz (smtp2.woosh.co.nz [202.74.207.41]) by mx1.freebsd.org (Postfix) with ESMTP id 7C0D38FC08 for ; Tue, 4 Sep 2012 02:18:06 +0000 (UTC) Received: from 202-74-193-82.static.woosh.co.nz ([202.74.193.82] helo=[192.168.42.9]) by smtp2.woosh.co.nz with esmtp (Exim 4.77) (envelope-from ) id 1T8iFJ-0000h1-Pp; Tue, 04 Sep 2012 13:48:05 +1200 Message-ID: <50455DD3.9070808@ianshome.com> Date: Tue, 04 Sep 2012 13:48:03 +1200 From: Ian Collins User-Agent: Mozilla/5.0 (X11; SunOS i86pc; rv:12.0) Gecko/20120423 Thunderbird/12.0 MIME-Version: 1.0 To: zfs@lists.illumos.org References: <50438BF5.8030004@gibfest.dk> <5043B0CB.8040907@gibfest.dk> <20120902193100.GG1266@glenbarber.us> <5043B866.6060204@nexenta.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-fs , Matthew Ahrens , Yuri Pankov Subject: Re: [zfs] Re: zfs send -r missing - but documented in zfs(8) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Sep 2012 02:18:06 -0000 On 09/ 4/12 05:25 AM, Matthew Ahrens wrote: > On Sun, Sep 2, 2012 at 12:49 PM, Yuri Pankov wrote: >> On Sun, 2 Sep 2012 15:31:00 -0400, Glen Barber wrote: >>> On Sun, Sep 02, 2012 at 09:17:31PM +0200, Thomas Steen Rasmussen wrote: >>>>> Hello list, >>>>> >>>>> For some reason it seems like the -r argument to "zfs send" isn't >>>>> implemented in FreeBSD. It is documented in the usage output >>>>> seen below: >>>>> >>>>> >>>>> I had a similar experience with out-of-sync docs and then I think a >>>>> missing mergemaster might have had something to do with it. >>>>> >>>> Hello, >>>> >>>> This is not just the manpage out of sync. Ironically >>>> the zfs tool itself reports the lower-case -r option >>>> in the usage output that it shows me because -r >>>> is an invalid option: >>>> >>>> ------------------------------------------------------------ >>>> $ zfs send -r >>>> invalid option 'r' >>>> usage: >>>> send [-DnPpRrv] [-i snapshot | -I snapshot] >>>> >>> I reported this to Martin a few days ago, but not yet had time myself to >>> check if this is also a bug upstream. >> >> Talking about upstream, looks like -r was added to usage and man page in >> r13524 by Matthew Ahrens (CCed), but the functionality itself is missing. > Indeed. This was a mistake. A long time ago we intended to implement > this flag, but it was never integrated. I think I typo'ed the options > string in the zfs command; and then when writing the manpage I > remembered that long-lost implementation. > > In any case, we should remove the documentation of the "zfs send -r" > flag, as that flag doesn't actually exist. It is implemented (and useful, I used it today!) in Solaris 11. Will it ever follow on to illumos? -- Ian.