From owner-freebsd-ports Sun Sep 9 17:14:12 2001 Delivered-To: freebsd-ports@freebsd.org Received: from heaven.gigo.com (gigo.com [207.173.11.186]) by hub.freebsd.org (Postfix) with ESMTP id E5A6737B40A for ; Sun, 9 Sep 2001 17:14:06 -0700 (PDT) Received: from 200.181.49.206 (unknown [200.181.49.206]) by heaven.gigo.com (Postfix) with ESMTP id 80AC2B847 for ; Sun, 9 Sep 2001 17:12:20 -0700 (PDT) Received: (qmail 5472 invoked by uid 1001); 9 Sep 2001 21:14:50 -0000 From: "Mario Sergio Fujikawa Ferreira" Date: Sun, 9 Sep 2001 21:14:28 +0000 To: freebsd-ports@FreeBSD.org Cc: andy@digitalspecies.com Subject: [andy@digitalspecies.com: qpopper patch] Message-ID: <20010909211428.B5452@exxodus.fedaykin.here> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Hi, I received this patch to qpopper 4.0.3 It looks sane, it feels sane, does not break the protocol... but is anyone relying on the blank lines? Should I still support them? Or, can I nuke them as the submitter of the patch proposes? Just trying to find out if this is going to break something major. Also, should I patch this? Or, submit this to the developers and hope for some change in next version since this is more cosmetic than a fix. What's the standard policy? Regards, ----- Forwarded message from Andy Raffle ----- Delivered-To: lioux-freebsd@localhost X-From_: root Sun Sep 9 13:34:07 2001 Delivered-To: lioux@freebsd.org Date: Sun, 9 Sep 2001 17:31:22 +0100 From: Andy Raffle To: lioux@FreeBSD.org Subject: qpopper patch User-Agent: Mutt/1.2.5i Hi! Are you still the maintainer of the qpopper port? I've never submitted a patch or diff before, so I'm sorry if I've done it wrong, but here are two diff files that I believe should be incorporated into qpopper 4.0.3. When compiling with the WITH_FULL_POPD_DEBUG=yes option, the trace file that is created has the format: Sep 9 18:51:25.410 2001 [92592] Received (4): "STAT" [pop_get_command.c:105] Sep 9 18:51:25.410 2001 Sep 9 18:51:25.411 2001 [92592] 0 visible message(s) (0 octets). [pop_stat.c:39] Sep 9 18:51:25.411 2001 Sep 9 18:51:25.411 2001 [92592] +OK 0 0 [pop_stat.c:41] Sep 9 18:51:25.411 2001 Sep 9 18:51:25.411 2001 [92592] stat returned 1; CurrentState now trans [popper.c:329] Sep 9 18:51:25.411 2001 So there is an effectively blank log line between each message. The diffs attached to this email should remove that. Hope this is of some help! Andy. -- Andy Raffle --- common/logit.c.orig Wed Apr 4 01:23:03 2001 +++ common/logit.c Sun Sep 9 18:29:40 2001 @@ -182,9 +182,7 @@ pYear = pDate + ( iDateLen - 5 ); /* point to start of year */ date_time [ iDateLen - 2 ] = '\0'; /* cut off the year */ lMsec = (tval.tv_usec + 500) / 1000; /* convert useconds to milliseconds */ - fprintf ( str, "%s.%03ld %.4s [%ld] %s\n", - pDate, lMsec, pYear, (long) getpid(), msgbuf ); - fprintf ( str, "%s.%03ld %.4s \n", pDate, lMsec, pYear ); + fprintf ( str, "%s.%03ld %.4s [%ld] %s\n", pDate, lMsec, pYear, (long) getpid(), msgbuf ); fflush ( str ); } else { @@ -196,9 +194,7 @@ * We blew out the format buffer. */ if ( str ) { - fprintf ( str, "%s [%ld] Buffer size exceeded logging msg: %s\n", - date_time, (long) getpid(), format ); - fprintf ( str, "%s \n", date_time ); + fprintf ( str, "%s [%ld] Buffer size exceeded logging msg: %s\n", date_time, (long) getpid(), format ); fflush ( str ); } else { --- popper/pop_log.c.orig Wed Apr 4 01:23:33 2001 +++ popper/pop_log.c Sun Sep 9 18:38:40 2001 @@ -136,9 +136,7 @@ pYear = pDate + ( iDateLen - 5 ); /* point to start of year */ date_time [ iDateLen - 2 ] = '\0'; /* cut off the year */ lMsec = (tval.tv_usec + 500) / 1000; /* convert useconds to milliseconds */ - fprintf ( p->trace, "%s.%03ld %.4s [%ld] %s\n", - pDate, lMsec, pYear, (long) getpid(), msgbuf ); - fprintf ( p->trace, "%s.%03ld %.4s \n", pDate, lMsec, pYear ); + fprintf ( p->trace, "%s.%03ld %.4s [%ld] %s\n", pDate, lMsec, pYear, (long) getpid(), msgbuf ); fflush ( p->trace ); } else { @@ -150,9 +148,7 @@ * We blew out the format buffer. */ if ( p->debug && p->trace ) { - fprintf ( p->trace, "%s [%ld] Buffer size exceeded logging msg: %s\n", - date_time, (long) getpid(), format ); - fprintf ( p->trace, "%s \n", date_time ); + fprintf ( p->trace, "%s [%ld] Buffer size exceeded logging msg: %s\n", date_time, (long) getpid(), format ); fflush ( p->trace ); } else { ----- End forwarded message ----- -- Mario S F Ferreira - UnB - Brazil - "I guess this is a signature." lioux at ( freebsd dot org | linf dot unb dot br ) flames to beloved devnull@someotherworldbeloworabove.org feature, n: a documented bug | bug, n: an undocumented feature To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message