From owner-svn-src-head@FreeBSD.ORG Fri Nov 16 21:38:44 2012 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DABB05B9; Fri, 16 Nov 2012 21:38:44 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from vps.rulingia.com (host-122-100-2-194.octopus.com.au [122.100.2.194]) by mx1.freebsd.org (Postfix) with ESMTP id 374278FC08; Fri, 16 Nov 2012 21:38:43 +0000 (UTC) Received: from server.rulingia.com (c220-239-241-202.belrs5.nsw.optusnet.com.au [220.239.241.202]) by vps.rulingia.com (8.14.5/8.14.5) with ESMTP id qAGLcehJ088806 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 17 Nov 2012 08:38:41 +1100 (EST) (envelope-from peter@rulingia.com) X-Bogosity: Ham, spamicity=0.000000 Received: from server.rulingia.com (localhost.rulingia.com [127.0.0.1]) by server.rulingia.com (8.14.5/8.14.5) with ESMTP id qAGLcWr4095829 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 17 Nov 2012 08:38:33 +1100 (EST) (envelope-from peter@server.rulingia.com) Received: (from peter@localhost) by server.rulingia.com (8.14.5/8.14.5/Submit) id qAGLcVcT095827; Sat, 17 Nov 2012 08:38:31 +1100 (EST) (envelope-from peter) Date: Sat, 17 Nov 2012 08:38:31 +1100 From: Peter Jeremy To: Dimitry Andric Subject: Re: svn commit: r242625 - in head/sys: dev/ale dev/ata dev/ata/chipsets dev/ath/ath_hal/ar5212 dev/bge dev/cas dev/dc dev/flash dev/fxp dev/gem dev/lge dev/mii dev/nge dev/pci dev/re dev/sis dev/ste de... Message-ID: <20121116213831.GW36898@server.rulingia.com> References: <201211051916.qA5JGRDr064585@svn.freebsd.org> <5098416C.3040802@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="O8XZ+2Hy8Kj8wLPZ" Content-Disposition: inline In-Reply-To: <5098416C.3040802@FreeBSD.org> X-PGP-Key: http://www.rulingia.com/keys/peter.pgp User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@FreeBSD.org, Adrian Chadd , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Nov 2012 21:38:45 -0000 --O8XZ+2Hy8Kj8wLPZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2012-Nov-05 23:45:00 +0100, Dimitry Andric wrote: >On 2012-11-05 23:36, Adrian Chadd wrote: >> I'm fine with the change, but why didn't you run this by the various >> driver owners first before doing a drive-by commit? > >The change was trivial, and did not cause any binary difference. I see >no reason to bother 20 different maintainers with something like this, >except bureaucratic ones... :) A bit belated but I think you've missed the most important reason why you should warn maintainers: You can be creating additional effort for maintainers. There is an ongoing push to make head more stable by pushing experimental development into "private" branches which can then be merged back to head once the functionality is stable. Whilst there may not be a binary difference, you are creating source changes. If you've changed something that a maintainer is actively working on, they need to take the time to work out if the change is still relevant and whether it impacts the testing they have done. --=20 Peter Jeremy --O8XZ+2Hy8Kj8wLPZ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlCmslcACgkQ/opHv/APuIcjhQCfdfojhFm65IzT8IwUrn09pxHb cT0AnRkrdRX97DAF1WSlD9YpEhpwZDiG =PLKu -----END PGP SIGNATURE----- --O8XZ+2Hy8Kj8wLPZ--