From owner-svn-src-all@freebsd.org Wed Mar 16 22:56:47 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A6AFDAD240B; Wed, 16 Mar 2016 22:56:47 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-yw0-f170.google.com (mail-yw0-f170.google.com [209.85.161.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 704059AC; Wed, 16 Mar 2016 22:56:46 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-yw0-f170.google.com with SMTP id h129so80223048ywb.1; Wed, 16 Mar 2016 15:56:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc; bh=s1Jkula7ejgrvSpOebu5T7fXXPGk3csfEXljODUOBmg=; b=egM8sxennmXy6pCzwg9SWmXh/JRFsGW9sWM1s4Dmx9etl9AvUK2QOcf+8hQIJ9JcHf c/7pGHk2GNcGERnyxxaTgr5I9CkeSrGUvZ0l1ixe+FN+YUCzoqZc/prYSMPTZ5v4bIEU rvbPMCOQfUvw+FjeOr6fje8mzpqhFz5dSwYNtjEAv8CO1EWUdW+pj+fg0Eo3BePij29v JFx5p691e3Hb+Nt1ZH/12jamRvGLPH9CBUlMheG1bt2UpR1nbbokjAUl+smRRQKqGsBH CAj9+8BAXuOi8/Xd1oMeJcf/W3fADSse4VTeeKLRxEuYsMi/STPzQlAd85fdpG3LO/CJ 5PXQ== X-Gm-Message-State: AD7BkJJ6cwtij2DjPXfQETaVlwm7UBiySplTvJP/ADXYzhCVEyQIdilwh/d8AjJb9jbcTw== X-Received: by 10.37.109.198 with SMTP id i189mr2757684ybc.171.1458168999712; Wed, 16 Mar 2016 15:56:39 -0700 (PDT) Received: from mail-yw0-f180.google.com (mail-yw0-f180.google.com. [209.85.161.180]) by smtp.gmail.com with ESMTPSA id w127sm3320025ywd.13.2016.03.16.15.56.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Mar 2016 15:56:39 -0700 (PDT) Received: by mail-yw0-f180.google.com with SMTP id g3so80230708ywa.3; Wed, 16 Mar 2016 15:56:38 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.13.217.77 with SMTP id b74mr2790907ywe.73.1458168998737; Wed, 16 Mar 2016 15:56:38 -0700 (PDT) Reply-To: cem@FreeBSD.org Received: by 10.37.115.134 with HTTP; Wed, 16 Mar 2016 15:56:38 -0700 (PDT) In-Reply-To: References: <201603160422.u2G4MWg1012528@repo.freebsd.org> Date: Wed, 16 Mar 2016 15:56:38 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r296927 - in head: share/man/man9 sys/kern sys/sys From: Conrad Meyer To: "Bjoern A. Zeeb" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2016 22:56:47 -0000 Sorry. I guess that whole routine needs to be wrapped in #if defined(STACK). I'll work to put together a patch soon. Thanks, Conrad On Wed, Mar 16, 2016 at 3:02 PM, Bjoern A. Zeeb wrote: > On Wed, 16 Mar 2016, Conrad E. Meyer wrote: > >> Author: cem >> Date: Wed Mar 16 04:22:32 2016 >> New Revision: 296927 >> URL: https://svnweb.freebsd.org/changeset/base/296927 >> >> Log: >> fail(9): Upstreaming some fail point enhancements >> >> This is several year's worth of fail point upgrades done at EMC Isilon. >> They >> are interdependent enough that it makes sense to put a single diff up for >> them. >> Primarily, we added: >> >> - Changing all mainline execution paths to be lockless, which lets us use >> fail >> points in more sleep-sensitive areas, and allows more parallel >> execution >> - A number of additional commands, including 'pause' that lets us do some >> interesting deterministic repros of race conditions >> - The ability to dump the stacks of all threads sleeping on a fail point >> - A number of other API changes to allow marking up the fail point's >> context in >> the code, and firing callbacks before and after execution >> - A man page update >> >> Submitted by: Matthew Bryan >> Reviewed by: cem (earlier version), jhb, kib, pho >> With feedback from: bdrewery >> Sponsored by: EMC / Isilon Storage Division >> Differential Revision: https://reviews.freebsd.org/D5427 >> >> Modified: >> head/share/man/man9/fail.9 >> head/sys/kern/kern_fail.c >> head/sys/kern/subr_sleepqueue.c >> head/sys/sys/fail.h >> head/sys/sys/sleepqueue.h > > > This seems to have broken a few kernel configs (just one example); > > linking kernel.full > subr_sleepqueue.o: In function `sleepq_sbuf_print_stacks': > /scratch/tmp/bz/head.svn/sys/kern/subr_sleepqueue.c:(.text+0x448): undefined > reference to `stack_create' > /scratch/tmp/bz/head.svn/sys/kern/subr_sleepqueue.c:(.text+0x448): > relocation truncated to fit: R_MIPS_26 against `stack_create' > /scratch/tmp/bz/head.svn/sys/kern/subr_sleepqueue.c:(.text+0x504): undefined > reference to `stack_save_td' > /scratch/tmp/bz/head.svn/sys/kern/subr_sleepqueue.c:(.text+0x504): > relocation truncated to fit: R_MIPS_26 against `stack_save_td' > /scratch/tmp/bz/head.svn/sys/kern/subr_sleepqueue.c:(.text+0x598): undefined > reference to `stack_sbuf_print' > /scratch/tmp/bz/head.svn/sys/kern/subr_sleepqueue.c:(.text+0x598): > relocation truncated to fit: R_MIPS_26 against `stack_sbuf_print' > /scratch/tmp/bz/head.svn/sys/kern/subr_sleepqueue.c:(.text+0x5f0): undefined > reference to `stack_destroy' > /scratch/tmp/bz/head.svn/sys/kern/subr_sleepqueue.c:(.text+0x5f0): > relocation truncated to fit: R_MIPS_26 against `stack_destroy' > --- kernel.full --- > *** [kernel.full] Error code 1 > > bmake[5]: stopped in > /storage/head/obj/mips.mipsn32/scratch/tmp/bz/head.svn/sys/XLPN32