Date: Sat, 31 May 2014 08:09:36 -0700 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: Guido Falsi <madpilot@FreeBSD.org> Cc: freebsd-ports@freebsd.org Subject: Re: please revert graphics/xfig r354029 Message-ID: <20140531150936.GA60696@troutmask.apl.washington.edu> In-Reply-To: <5389EE92.5070105@FreeBSD.org> References: <20140531000800.GA57984@troutmask.apl.washington.edu> <5389D9B6.8030005@FreeBSD.org> <20140531143509.GA60572@troutmask.apl.washington.edu> <5389EE92.5070105@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, May 31, 2014 at 05:00:34PM +0200, Guido Falsi wrote: > On 05/31/14 16:35, Steve Kargl wrote: > > On Sat, May 31, 2014 at 03:31:34PM +0200, Guido Falsi wrote: > >> On 05/31/14 02:08, Steve Kargl wrote: > >>> Can someone please revert r354029 for graphics/xfig? > >>> This revision breaks the ability to install the port. > >>> > >>> cd /usr/ports/graphics/xfig > >>> svn merge -r 354029:340725 . > >>> > >> > >> Hi, > >> > >> I did commit the revision you mention. I just tested the port and it > >> installs fine. > > > > Not on my system, which is an up-to-date freebsd-current. > > > > After some digging I found out the port is broken when the DOCS option > is disabled. > > I'm cooking a fix I'll get to you soon. > > Please always report if using custom options when reporting a problem. > I forgot I had the DOCS option unset as it was unset ages ago and updates have always worked. The question is "why are changes to a port committed without proper testing?" Yes, "proper testing" should include testing of the effects of (un)setting individual Makefile options. -- Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140531150936.GA60696>