From owner-svn-src-all@freebsd.org Sun Mar 29 22:28:17 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4E17F266520; Sun, 29 Mar 2020 22:28:17 +0000 (UTC) (envelope-from grog@lemis.com) Received: from lax.lemis.com (www.lemis.com [45.32.70.18]) by mx1.freebsd.org (Postfix) with ESMTP id 48r9GS41S8z4KqJ; Sun, 29 Mar 2020 22:28:15 +0000 (UTC) (envelope-from grog@lemis.com) Received: from eureka.lemis.com (aussie-gw.lemis.com [167.179.139.35]) by lax.lemis.com (Postfix) with ESMTP id 8674527FF8; Sun, 29 Mar 2020 22:28:01 +0000 (UTC) Received: by eureka.lemis.com (Postfix, from userid 1004) id CE198263596; Mon, 30 Mar 2020 09:28:00 +1100 (AEDT) Date: Mon, 30 Mar 2020 09:28:00 +1100 From: Greg 'groggy' Lehey To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r359419 - head/usr.bin/ncal Message-ID: <20200329222800.GE87815@eureka.lemis.com> References: <202003290418.02T4IR46003292@repo.freebsd.org> <202003291103.02TB393j051396@gndrsh.dnsmgr.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oOB74oR0WcNeq9Zb" Content-Disposition: inline In-Reply-To: <202003291103.02TB393j051396@gndrsh.dnsmgr.net> Organization: The FreeBSD Project Phone: +61-3-5309-0418 Mobile: +61-490-494-038. Use only as instructed. WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 User-Agent: Mutt/1.6.1 (2016-04-27) X-Rspamd-Queue-Id: 48r9GS41S8z4KqJ X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Mar 2020 22:28:17 -0000 --oOB74oR0WcNeq9Zb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sunday, 29 March 2020 at 4:03:09 -0700, Rodney W. Grimes wrote: >> Author: grog >> Date: Sun Mar 29 04:18:27 2020 >> New Revision: 359419 >> URL: https://svnweb.freebsd.org/changeset/base/359419 >> >> Log: >> Remove spurious transition from Julian to Gregorian for country >> "Latin". >> >> Arguably the entire -p option should be removed. It shows only a few >> countries, and it doesn't have any relationship with the rest of the >> program. > > This commit message and the diff below do not seem to match very well. > Is this actually what you intended to commit? The material difference, yes. Do you have an issue with that? It seems that some trailing blanks in unrelated text were removed as well. diff doesn't show these by default, so they crept through. I know it's bad style to mix style commits with functional commits, but ultimately they had to go too. Greg -- Sent from my desktop computer. Finger grog@FreeBSD.org for PGP public key. See complete headers for address and phone numbers. This message is digitally signed. If your Microsoft mail program reports problems, please read http://lemis.com/broken-MUA --oOB74oR0WcNeq9Zb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAl6BIPAACgkQIubykFB6QiP9QACdGzjB3i4mqbxr9Vy+o01E3DWL 04AAn03kd3D1HAplOUsSuFN49t9mF/5c =HewY -----END PGP SIGNATURE----- --oOB74oR0WcNeq9Zb--