Date: Wed, 28 Jul 2021 10:25:21 -0700 From: Chris <i.h8.git@BSDforge.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Matthias Andree <mandree@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 17db9a3291e9 - main - Mk/bsd.port.mk: fix typo in .warning Message-ID: <d60a4b9fda511775ed46d15d08a97824@BSDforge.com> In-Reply-To: <YPk6d/9l1EAnX386@FreeBSD.org> References: <202107220923.16M9NTCs062056@gitrepo.freebsd.org> <YPk6d/9l1EAnX386@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2021-07-22 02:29, Alexey Dokuchaev wrote:
> On Thu, Jul 22, 2021 at 09:23:29AM +0000, Matthias Andree wrote:
>> commit 17db9a3291e9e8b62af035ee1b22160be465976a
>>
>> Mk/bsd.port.mk: fix typo in .warning
>>
>> vertion -> version.
>>
>> --- a/Mk/bsd.port.mk
>> +++ b/Mk/bsd.port.mk
>> @@ -1216,7 +1216,7 @@ _PKG_BEFORE_PKGEXT!= ${PKG_BIN} version -t
>> ${_PKG_VERSION:C/-.*//g} 1.17.0
>> .if ${_PKG_BEFORE_PKGEXT} == "<"
>> _PKG_TRANSITIONING_TO_NEW_EXT= yes
>> _EXPORTED_VARS+= _PKG_TRANSITIONING_TO_NEW_EXT
>> -.warning "It is strongly recommanded to upgrade to a newer vertion of pkg
>> first"
>> +.warning "It is strongly recommanded to upgrade to a newer version of pkg
>> first"
>
> When fixing typos, it's usually a good idea to check if thre are more
> of them around (e.g., "recommanded"). I'd probably just grepped for
> .warning and .error strings and run aspell(1) over them.
>
> ./danfe
A humble suggestion to change:
.warning "It is strongly recommanded to upgrade to a newer version of pkg
first
to
.warning "It is strongly recommended that you upgrade to a newer version of
pkg first
or
.warning "You are strongly encouraged to upgrade to a newer version of pkg
first
FWIW :-)
--Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d60a4b9fda511775ed46d15d08a97824>