From owner-svn-src-all@FreeBSD.ORG Wed Feb 4 21:23:56 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C82A7706; Wed, 4 Feb 2015 21:23:56 +0000 (UTC) Received: from mail-ig0-x22d.google.com (mail-ig0-x22d.google.com [IPv6:2607:f8b0:4001:c05::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8CE8E95D; Wed, 4 Feb 2015 21:23:56 +0000 (UTC) Received: by mail-ig0-f173.google.com with SMTP id a13so37765800igq.0; Wed, 04 Feb 2015 13:23:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=LgNYT2BcLf/Ve+XmTfAVRU8jgxyBdsT9MenVRVYb3xc=; b=ImRi9r4ySiOTAqwxno1lk9c/Z15xOrjzGi0y3XIZXTAhFAf8xCR0IaEnjB/BpkHNRh adKwhzv3dhCUgtVMTGEF0HJ9RUDZSNl2J8iWHc1mTz34G5LWkcKY7xz1HTaqycapMptn vu9mNL6QE3jPeJyPsuk5xq0Gae2w+OP8EOUuYA38l1vPdza2P17Ax7LNbK/qTHoHbSJ/ 2NoAyswPJjoa52vpswOj9k6gzZ00SaDIEaP+RmnIxYOzna35qrDJ3YP/8WDUL8rBfdYh BKhDWLRsuKgAgCS/Z3wQudGJwSprXPNXRjI3cFxzHHGFO/QZczL29YUZSsI84VFmbkz9 XL+A== MIME-Version: 1.0 X-Received: by 10.50.137.99 with SMTP id qh3mr4756810igb.7.1423085036008; Wed, 04 Feb 2015 13:23:56 -0800 (PST) Received: by 10.50.182.233 with HTTP; Wed, 4 Feb 2015 13:23:55 -0800 (PST) In-Reply-To: <7338E032-8668-44D2-AE98-C3E50E512DDD@FreeBSD.org> References: <201502042100.t14L0Ued055489@svn.freebsd.org> <7338E032-8668-44D2-AE98-C3E50E512DDD@FreeBSD.org> Date: Wed, 4 Feb 2015 13:23:55 -0800 Message-ID: Subject: Re: svn commit: r278223 - head/lib/clang From: NGie Cooper To: Dimitry Andric Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Feb 2015 21:23:56 -0000 On Wed, Feb 4, 2015 at 1:16 PM, Dimitry Andric wrote: > On 04 Feb 2015, at 22:09, NGie Cooper wrote: >> >> On Wed, Feb 4, 2015 at 1:00 PM, Dimitry Andric wrote: >>> Author: dim >>> Date: Wed Feb 4 21:00:29 2015 >>> New Revision: 278223 >>> URL: https://svnweb.freebsd.org/changeset/base/278223 >>> >>> Log: >>> For now, add -stdlib=libc++ to the flags for building clang, since that >>> makes it easier to build head on stable/9, where libstdc++ is still the >>> default. We can revisit this when somebody will try to build base with >>> gcc 4.8.1 or higher, and its included libstdc++. >> >> Maybe this should be conditionalized on COMPILER_TYPE? > > COMPILER_TYPE doesn't say anything about the C++ library used. Maybe we > need a CXX_LIBRARY_TYPE setting for it? > > That said, you may be right that it should be conditionalized on the > compiler type anyway, since gcc does not support the -stdlib= option. Yeah... true. My original point was coming more from a perspective that this was being done strictly for the GNU toolchain, so conditionalizing the CFLAGS on the compiler being used seemed reasonable. Thanks!