From owner-svn-src-all@freebsd.org Fri Jul 13 04:29:34 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4AF081025E54; Fri, 13 Jul 2018 04:29:34 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-qt0-x243.google.com (mail-qt0-x243.google.com [IPv6:2607:f8b0:400d:c0d::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C8E6573BA6; Fri, 13 Jul 2018 04:29:33 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-qt0-x243.google.com with SMTP id z8-v6so17587815qto.9; Thu, 12 Jul 2018 21:29:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ozBuKjhD1akUbd+hSjdqVfcvwyHhExoo+yZGXmXvS7Q=; b=CCxQrEaOW94Gwbd7lu6wizUROZ81HwIIjVD1QUhq4wCQuNsXs7ZGjUTni/MTRj6VAo lW+NXS3r2EIEzAHNTqivSY90Ul2ADWZvJ1ykNquPWpsWXdUz8jd/gIGLA8cNwegmPws/ bTMAIS019eTbOBeuUKKGQ5bdu8pHnc0V4KTJyPoHNxNh1FQoXpe3HGYunPpLyMVNG4CN +KGx3wGeuqYGgWb+uYkIQ2HoMIH0wYHFff+AwTYCdzyB+750MVgsD/ABnUYuEIsEvXei FnurjTJvLDMauhPMIRWnA+dP1ESLjHDwnLMR1Ak47zlDsi3Ig2JTZIFveJue227cWg6c RuhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ozBuKjhD1akUbd+hSjdqVfcvwyHhExoo+yZGXmXvS7Q=; b=Th1RwEV7i6VCEUF0+7OVUfWGpqcKPUGUtVE+NbBnEIV53+kfIXh94VMDWpviSykgnP Bkoma60FbcGyMP7DGaFHYd5ozsEz3x5nZ4hH/hZEGHNWmQA2UOsFqUOCkBZExAmwGi4T okdbMmJ/axv1CVLGoXZUJJ0zwBDHbKF8BgeQ/TyA97prQA4LD6I9txpWtpHYIiP1mxuc SgJMXmyKylSH7hzJvdHhLuL8oOZa8uMM6UE/MztuQZAOFrTcKZt5v6JQ+aBANLBTnHGG GuyV97ak+IH0+dEN3pv+IPcAko2VAY/U6z6G2ms8AnzWY3HabvKrdLVosxF3K0FmKqJN MlUQ== X-Gm-Message-State: AOUpUlEfseu6kEzHbAMYN/BGyUMalOg73wupyJfDg93QfQaIOz2XIECX 1KdQWgxtG9pjK4/XkO0MBLxHTtmeWpDhDjsGrJQ= X-Google-Smtp-Source: AAOMgpcQa8kZqFMz1uoQBXuBmEBJnUxFxaZnYtaj0R6BhEFLjpxw8F4qkFeMSItf4J82Zdj8hDQA4Eo6uQlrwgylbj4= X-Received: by 2002:ac8:3417:: with SMTP id u23-v6mr4200872qtb.237.1531456173244; Thu, 12 Jul 2018 21:29:33 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:aed:2807:0:0:0:0:0 with HTTP; Thu, 12 Jul 2018 21:29:32 -0700 (PDT) In-Reply-To: <20180713033951.GB26064@raichu> References: <201807122235.w6CMZqO8030291@repo.freebsd.org> <20180712225856.GA26064@raichu> <20180713033951.GB26064@raichu> From: Mateusz Guzik Date: Fri, 13 Jul 2018 06:29:32 +0200 Message-ID: Subject: Re: svn commit: r336231 - head/sys/vm To: Mark Johnston Cc: Mateusz Guzik , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 04:29:34 -0000 they are modified in 2 places: zone_alloc_item and zone_free_item. this should probably get fixed up at some point, but I have no interest in working on it. On Fri, Jul 13, 2018 at 5:39 AM, Mark Johnston wrote: > On Fri, Jul 13, 2018 at 01:41:46AM +0200, Mateusz Guzik wrote: > > uma_zone_get_cur iterates the per-cpu stats and looks at the zone-global > > stats. The patch only gets rid of rolling them up, thus there is no > > difference from the pov of this func. > > I don't follow the remark about uma_reclaim. > > I'm pointing out that with this change we no longer maintain any > zone-global stats. > > > On Fri, Jul 13, 2018 at 12:58 AM, Mark Johnston > wrote: > > > > > On Thu, Jul 12, 2018 at 10:35:52PM +0000, Mateusz Guzik wrote: > > > > Author: mjg > > > > Date: Thu Jul 12 22:35:52 2018 > > > > New Revision: 336231 > > > > URL: https://svnweb.freebsd.org/changeset/base/336231 > > > > > > > > Log: > > > > uma: whack main zone counter update in the slow path, freeing side > > > > > > > > See r333052. > > > > > > > > Modified: > > > > head/sys/vm/uma_core.c > > > > > > > > Modified: head/sys/vm/uma_core.c > > > > ============================================================ > > > ================== > > > > --- head/sys/vm/uma_core.c Thu Jul 12 22:34:40 2018 > (r336230) > > > > +++ head/sys/vm/uma_core.c Thu Jul 12 22:35:52 2018 > (r336231) > > > > @@ -3135,14 +3135,6 @@ zfree_start: > > > > cpu = curcpu; > > > > cache = &zone->uz_cpu[cpu]; > > > > > > > > - /* > > > > - * Since we have locked the zone we may as well send back our > > > stats. > > > > - */ > > > > - atomic_add_long(&zone->uz_allocs, cache->uc_allocs); > > > > - atomic_add_long(&zone->uz_frees, cache->uc_frees); > > > > - cache->uc_allocs = 0; > > > > - cache->uc_frees = 0; > > > > - > > > > > > Doesn't this break the accounting of these stats? uma_reclaim() > doesn't > > > update them when it frees cached items, and uma_zone_get_cur() doesn't > > > look at the stats for cached buckets. > -- Mateusz Guzik