From owner-freebsd-fs@FreeBSD.ORG Sun Jul 31 23:33:19 2011 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4F809106566C; Sun, 31 Jul 2011 23:33:19 +0000 (UTC) (envelope-from prvs=1193afe4ca=killing@multiplay.co.uk) Received: from mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) by mx1.freebsd.org (Postfix) with ESMTP id 6785B8FC0A; Sun, 31 Jul 2011 23:33:17 +0000 (UTC) X-MDAV-Processed: mail1.multiplay.co.uk, Mon, 01 Aug 2011 00:32:45 +0100 X-Spam-Processed: mail1.multiplay.co.uk, Mon, 01 Aug 2011 00:32:45 +0100 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on mail1.multiplay.co.uk X-Spam-Level: X-Spam-Status: No, score=-5.0 required=6.0 tests=USER_IN_WHITELIST shortcircuit=ham autolearn=disabled version=3.2.5 Received: from r2d2 ([188.220.16.49]) by mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) (MDaemon PRO v10.0.4) with ESMTP id md50014409919.msg; Mon, 01 Aug 2011 00:32:45 +0100 X-MDRemoteIP: 188.220.16.49 X-Return-Path: prvs=1193afe4ca=killing@multiplay.co.uk X-Envelope-From: killing@multiplay.co.uk Message-ID: <0E851F439C384186A1D44A347C19A7D7@multiplay.co.uk> From: "Steven Hartland" To: "Martin Matuska" , "David P Discher" References: <0D449EC916264947AB31AA17F870EA7A@multiplay.co.uk> <4E3013DF.10803@FreeBSD.org> <3D6CEB50BEDD4ACE96FD35C4D085618A@multiplay.co.uk> <4E301C55.7090105@FreeBSD.org> <5C84E7C8452E489C8CA738294F5EBB78@multiplay.co.uk> <4E301F10.6060708@FreeBSD.org> <63705B5AEEAD4BB88ADB9EF770AB6C76@multiplay.co.uk> <4E302204.2030009@FreeBSD.org> <6703F0BB-D4FC-4417-B519-CAFC62E5BC39@bitgravity.com> <04C305AE5F184C6AAC2A67CE23184013@multiplay.co.uk> <3D893A9B-2CD9-40EB-B4A2-5DBCBB72C62E@bitgravity.com> <4E35D2E5.4020108@FreeBSD.org> Date: Mon, 1 Aug 2011 00:33:11 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="utf-8"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 Cc: freebsd-fs@FreeBSD.org, Andriy Gapon Subject: Re: zfs process hang on pool access X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jul 2011 23:33:19 -0000 ----- Original Message ----- From: "Martin Matuska" >I walked through all occurences of ddi_get_lbolt() in the ZFS code and > this is the only place where it is incorrectly initialized. > This is how it should look like. > > =================================================================== > --- sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c (revision 224527) > +++ sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c (working copy) > @@ -488,7 +488,7 @@ > txg_delay(dsl_pool_t *dp, uint64_t txg, int ticks) > { > tx_state_t *tx = &dp->dp_tx; > - int timeout = ddi_get_lbolt() + ticks; > + clock_t timeout = ddi_get_lbolt() + ticks; So you recon that one line will fix the 100+ days overflow David's talking about? Regards Steve ================================================ This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it. In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337 or return the E.mail to postmaster@multiplay.co.uk.