From owner-freebsd-geom@FreeBSD.ORG Thu Oct 23 17:15:48 2008 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8953D1065670 for ; Thu, 23 Oct 2008 17:15:48 +0000 (UTC) (envelope-from marius@nuenneri.ch) Received: from wf-out-1314.google.com (wf-out-1314.google.com [209.85.200.175]) by mx1.freebsd.org (Postfix) with ESMTP id 65F898FC16 for ; Thu, 23 Oct 2008 17:15:48 +0000 (UTC) (envelope-from marius@nuenneri.ch) Received: by wf-out-1314.google.com with SMTP id 24so424061wfg.7 for ; Thu, 23 Oct 2008 10:15:47 -0700 (PDT) Received: by 10.115.19.16 with SMTP id w16mr907912wai.102.1224782147750; Thu, 23 Oct 2008 10:15:47 -0700 (PDT) Received: by 10.115.89.3 with HTTP; Thu, 23 Oct 2008 10:15:47 -0700 (PDT) Message-ID: Date: Thu, 23 Oct 2008 19:15:47 +0200 From: "=?ISO-8859-1?Q?Marius_N=FCnnerich?=" To: "Marcel Moolenaar" In-Reply-To: <29F8C203-E193-4D4A-91E3-2545AA0594BD@mac.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <29F8C203-E193-4D4A-91E3-2545AA0594BD@mac.com> Cc: Ivan Voras , freebsd-geom@freebsd.org Subject: Re: [PATCH] Teach geom_label to recognise gpt labels and uuids X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Oct 2008 17:15:48 -0000 On Thu, Oct 23, 2008 at 6:35 PM, Marcel Moolenaar wrote: > > On Oct 23, 2008, at 9:21 AM, Marius N=FCnnerich wrote: > >>> Something to think about: A system can have multiple disks, >>> and therefore multiple GPT tables. Each table has its own >>> UUID (hdr_uuid). This is the UUID of the disk itself in a >>> way. It's probably a good idea to expose that as well: >>> /dev/gpt/${hdr_uuid}/${ent_uuid} >>> /dev/gpt/${hdr_uuid}/${ent_name} >> >> I tried something like this but decided against it, no other g_label >> is like this. If ent_name is not unique on the system only the first >> one is shown, that's consistent with the normal FS labels. > > The consistency seems forced, based on a limitation then. > It's quite valuable to have a label for your disk. Sure, but a clean /dev namespace too :) The problem can still get you, for example if you copy a disc blockwise, you have the same hdr_uuid. I think the user should be sane enough to use different gpt labels/names or live with the consequences. >>> ese are too long filenames imo. For my taste the ent_uuid is unique >> >> enough as a filename, but there should probably be a way to show which >> partition has which ent_uuid with `gpart show`. > > gpart show has 3 forms: > o standard partition type (gpart show > ns1% gpart show ad5 > =3D> 34 976773101 ad5 GPT (500.1GB) > 34 976773101 1 freebsd-zfs (500.1GB) > > o raw (scheme-specific) type (gpart show -r) > ns1% gpart show -r ad5 > =3D> 34 976773101 ad5 GPT (500.1GB) > 34 976773101 1 516e7cba-6ecf-11d6-8ff8-00022d09712b > (500.1GB) > > o partition label (gpart show -l) > ns1% gpart show -l ad5 > =3D> 34 976773101 ad5 GPT (500.1GB) > 34 976773101 1 (null) (500.1GB) > > > There's currently no form for showing a partition ID. > >> I know that you try to >> keep the interface consistent and the other partition types don't have >> such a field. Anyway, what do you think about that? > > It can be added if deemed useful, but it only really > applies to GPT... I would find it useful, especially for scripting, now I would have to look at the dmesg output from geom_label with my patch :) But it's of course your decision. I don't know how much trouble it would be to add. - Marius P.S. I updated the patch again