From nobody Thu May 22 18:24:36 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4b3Gsc7278z5x0b2; Thu, 22 May 2025 18:24:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4b3Gsc6Hv0z3T9f; Thu, 22 May 2025 18:24:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747938276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sGlONyEN46XHoM9mn8F7200cYkv656eIFogJ+KlVF8w=; b=N4lKhqw4nj5cP4YOFAYtYZPrmhaqF8SLzjY1WIXMoCaadw1+ZFs3FVbNZgi/xx7KbO5BL2 I/g1z6kf7T8J86BNpcMEe1yGYT1F6pALVMI6Gb5wyU1dQG94hUGjsx8p2SHE4QnvuCo3Mw fsTs6f8YScLkmwN681BivpaBgakX0DG0e7jEMhNgeNNuPUNT1goKdZ1K4jwjr3qnLYEqqw Givhvv3l4YZzPGlthvcxRbTGjV5grlZLmiplaXQQDVNjBDKMFZpGXm0DDhg4iIBk1G/nfI 2h76nDBLesRY8ekk9MDlOFOcrsOkOwMvVhpK3/y72j84RZuEAi9lPbiOhnTLSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747938276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sGlONyEN46XHoM9mn8F7200cYkv656eIFogJ+KlVF8w=; b=hAQQ5eY6twOSa4D624MPYuky0qPjwqpLQ3BOs0zqjd00oPtL7cAP3k6Phjecp4l5DFH/Wu xl9oB5qJ7ocZNQortclCzmnVGlwlc8ZljNXgZUvsL442Af2IRAgvOfsrvCEiogySdameMp pWSR0dsi1mvC+WMLAZLihiUB2tgbk96TaurMxFCdTndo//e4bsSx3YQezhy3YBGp78Ismt a4gP4gPZ3k3nmpuwmmAGh6FoO77lD5SXDn8dLNMq+v4D+EYk/ZO4I48K1fwA+gq7+8xgz7 9lG7sZvV/X81HAqsTLjYqjNV6f+xWeTdrFbUH0GX/zDaYuV9Pp9IJxD8gcAByQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1747938276; a=rsa-sha256; cv=none; b=aQVEoMWp7+sItSp0EowcCrSDCDeWk4/J6RWHCwBKjwbuuSa1VwQAPEi9OjS36l4YPIUn8L 6avD13V5YW5LJhE9SFqJiwQGA8R2CozgIyF2O94Yz6+8Myw546j4ircQjR8Q21wQ6BjbTU 54F0QCTg2ZrBo18WfqUv7mAuUf/rF3ez6amrZ9S6TxvOhjdjrYYrsctxRl21kz7/LTbDiu YD5CiURhrHA5McOx58Ud0U2JTtEHMhrxJlQjpSvTBvMoM8nJY/7UWPZhKTPJuMWRvfuoXj cKl+wi9p0msdOD98DA7K5WtsZKnqAGocUhMQrWojpRYMVxaUamXPzQMX+Yz2FQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4b3Gsc5vNfzY4K; Thu, 22 May 2025 18:24:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 54MIOa9l047187; Thu, 22 May 2025 18:24:36 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 54MIOak8047184; Thu, 22 May 2025 18:24:36 GMT (envelope-from git) Date: Thu, 22 May 2025 18:24:36 GMT Message-Id: <202505221824.54MIOak8047184@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Christos Margiolis Subject: git: 0325cd325deb - stable/14 - sndctl(8): Remove unnecessary val variable from sysctl functions List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 0325cd325debb26b922c26425a3cc6bc4bcc3896 Auto-Submitted: auto-generated The branch stable/14 has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=0325cd325debb26b922c26425a3cc6bc4bcc3896 commit 0325cd325debb26b922c26425a3cc6bc4bcc3896 Author: Christos Margiolis AuthorDate: 2025-05-21 19:31:17 +0000 Commit: Christos Margiolis CommitDate: 2025-05-22 18:24:28 +0000 sndctl(8): Remove unnecessary val variable from sysctl functions No functional change intended. Sponsored by: The FreeBSD Foundation MFC after: 1 day Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D50397 (cherry picked from commit ac86e65e0e25a3e3fd6f91b17d2db874cea83c3b) --- usr.sbin/sndctl/sndctl.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/usr.sbin/sndctl/sndctl.c b/usr.sbin/sndctl/sndctl.c index f362ce840cf7..412ea33e5adf 100644 --- a/usr.sbin/sndctl/sndctl.c +++ b/usr.sbin/sndctl/sndctl.c @@ -662,12 +662,11 @@ static int sysctl_int(const char *buf, const char *arg, int *var) { size_t size; - const char *val = arg; int n, prev; - n = strtol(val, NULL, 10); + n = strtol(arg, NULL, 10); if (errno == EINVAL || errno == ERANGE) { - warn("strtol(%s)", val); + warn("strtol(%s)", arg); return (-1); } @@ -699,7 +698,6 @@ static int sysctl_str(const char *buf, const char *arg, char *var, size_t varsz) { size_t size; - const char *val = arg; char prev[BUFSIZ]; char *tmp; @@ -710,10 +708,10 @@ sysctl_str(const char *buf, const char *arg, char *var, size_t varsz) return (-1); } - size = strlen(val); + size = strlen(arg); /* Apply new value. */ - if (sysctlbyname(buf, NULL, 0, val, size) < 0) { - warn("sysctlbyname(%s, %s)", buf, val); + if (sysctlbyname(buf, NULL, 0, arg, size) < 0) { + warn("sysctlbyname(%s, %s)", buf, arg); return (-1); } /* Get size of new string. */