From owner-cvs-all Thu Mar 7 11:16:20 2002 Delivered-To: cvs-all@freebsd.org Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.139.170]) by hub.freebsd.org (Postfix) with ESMTP id 5677237B402; Thu, 7 Mar 2002 11:15:56 -0800 (PST) Received: (from uucp@localhost) by storm.FreeBSD.org.uk (8.11.6/8.11.6) with UUCP id g27JFtv60326; Thu, 7 Mar 2002 19:15:55 GMT (envelope-from mark@grimreaper.grondar.za) Received: from grimreaper (localhost [127.0.0.1]) by grimreaper.grondar.org (8.12.2/8.12.2) with ESMTP id g27JD3RV038460; Thu, 7 Mar 2002 19:13:03 GMT (envelope-from mark@grimreaper.grondar.za) Message-Id: <200203071913.g27JD3RV038460@grimreaper.grondar.org> To: obrien@FreeBSD.org Cc: Mark Murray , "M. Warner Losh" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/rwall rwall.c References: <20020307105542.A61459@dragon.nuxi.com> In-Reply-To: <20020307105542.A61459@dragon.nuxi.com> ; from "David O'Brien" "Thu, 07 Mar 2002 10:55:42 PST." Date: Thu, 07 Mar 2002 19:13:03 +0000 From: Mark Murray Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > On Thu, Mar 07, 2002 at 04:31:22PM +0000, Mark Murray wrote: > > > But the two constructs are different. In the prior code, if mkstemp > > > returns -1, then fdopen wouldn't be called. In the new code it is. > > > > I have reverted this, folks! > > Thanks. I hate to ask... but I saw this type of change in other files > besides just rwall.c. rwall.c was just the one I picked to respond to. I've been doing this for months. M -- o Mark Murray \_ O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message