From owner-svn-src-head@freebsd.org Wed Feb 27 13:10:10 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CC794151CBEA for ; Wed, 27 Feb 2019 13:10:10 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3A38475D52; Wed, 27 Feb 2019 13:10:10 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-lj1-f174.google.com with SMTP id l5so13939382lje.1; Wed, 27 Feb 2019 05:10:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=69o+or7Zj/0xwOE9iXPQ+Sirao8ymBJxBpN1j0aU0/o=; b=qzeq7Pjf9K7l/CYzN5iueA1UQm/fNnEnnSyKyXI6qzIZm0b1SagBULa72tp5ym/THX dA+OIA/biVhkdtydSFS3Losc2pPurcBzsThqu2sVddWBFdOrcul5Xxq/BTOf+EBDvr9D oA8V53fHKvSoS4uodbH10p4/NsBqpnGeZu9tKKUJSHlCP9dM/j4ujbSCYonINs+uDRGu wvofy6xJQtKG5RO3hCbHRzNiNKtNKVjibHkT+oAEOmiJKetfBDLJMJunASyvBVXgAeGY DtAyT31UX6mpEVMWQ4iwHgwJlbdcZ5pm5w/KA57SjL2MZB1wSGfRrMgcp8wlyh4QynaK ZBfg== X-Gm-Message-State: AHQUAuaLH0xgKuvyNIeHiFWz+jzwPCkyBeDhZpshBJxj+h8gviR6dQan oW0CRqwzCqj4ZZ7SDWiyUQ+6Xwm6 X-Google-Smtp-Source: APXvYqwQFCI/M6C72UACsvs1lAwNmr0cNvDFgBN9HdonR3s9MGsIflhrzeMsMAjkMnBwXL0RxK/WVw== X-Received: by 2002:a2e:9a8b:: with SMTP id p11mr1431082lji.66.1551273002618; Wed, 27 Feb 2019 05:10:02 -0800 (PST) Received: from [192.168.0.88] (east.meadow.volia.net. [93.72.151.96]) by smtp.googlemail.com with ESMTPSA id b26sm2083167lfa.5.2019.02.27.05.10.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Feb 2019 05:10:01 -0800 (PST) Subject: Re: svn commit: r344569 - in head/cddl/contrib/opensolaris: cmd/zfs lib/libzfs/common To: Cy Schubert Cc: Baptiste Daroussin , src-committers , svn-src-head@FreeBSD.org, Jack Halford References: <201902271304.x1RD4S6U051477@slippy.cwsent.com> From: Andriy Gapon Openpgp: preference=signencrypt Autocrypt: addr=avg@FreeBSD.org; prefer-encrypt=mutual; keydata= xsFNBFm4LIgBEADNB/3lT7f15UKeQ52xCFQx/GqHkSxEdVyLFZTmY3KyNPQGBtyvVyBfprJ7 mAeXZWfhat6cKNRAGZcL5EmewdQuUfQfBdYmKjbw3a9GFDsDNuhDA2QwFt8BmkiVMRYyvI7l N0eVzszWCUgdc3qqM6qqcgBaqsVmJluwpvwp4ZBXmch5BgDDDb1MPO8AZ2QZfIQmplkj8Y6Z AiNMknkmgaekIINSJX8IzRzKD5WwMsin70psE8dpL/iBsA2cpJGzWMObVTtCxeDKlBCNqM1i gTXta1ukdUT7JgLEFZk9ceYQQMJJtUwzWu1UHfZn0Fs29HTqawfWPSZVbulbrnu5q55R4PlQ /xURkWQUTyDpqUvb4JK371zhepXiXDwrrpnyyZABm3SFLkk2bHlheeKU6Yql4pcmSVym1AS4 dV8y0oHAfdlSCF6tpOPf2+K9nW1CFA8b/tw4oJBTtfZ1kxXOMdyZU5fiG7xb1qDgpQKgHUX8 7Rd2T1UVLVeuhYlXNw2F+a2ucY+cMoqz3LtpksUiBppJhw099gEXehcN2JbUZ2TueJdt1FdS ztnZmsHUXLxrRBtGwqnFL7GSd6snpGIKuuL305iaOGODbb9c7ne1JqBbkw1wh8ci6vvwGlzx rexzimRaBzJxlkjNfMx8WpCvYebGMydNoeEtkWldtjTNVsUAtQARAQABzR5BbmRyaXkgR2Fw b24gPGF2Z0BGcmVlQlNELm9yZz7CwZQEEwEIAD4WIQS+LEO7ngQnXA4Bjr538m7TUc1yjwUC WbgsiAIbIwUJBaOagAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRB38m7TUc1yj+JAEACV l9AK/nOWAt/9cufV2fRj0hdOqB1aCshtSrwHk/exXsDa4/FkmegxXQGY+3GWX3deIyesbVRL rYdtdK0dqJyT1SBqXK1h3/at9rxr9GQA6KWOxTjUFURsU7ok/6SIlm8uLRPNKO+yq0GDjgaO LzN+xykuBA0FlhQAXJnpZLcVfPJdWv7sSHGedL5ln8P8rxR+XnmsA5TUaaPcbhTB+mG+iKFj GghASDSfGqLWFPBlX/fpXikBDZ1gvOr8nyMY9nXhgfXpq3B6QCRYKPy58ChrZ5weeJZ29b7/ QdEO8NFNWHjSD9meiLdWQaqo9Y7uUxN3wySc/YUZxtS0bhAd8zJdNPsJYG8sXgKjeBQMVGuT eCAJFEYJqbwWvIXMfVWop4+O4xB+z2YE3jAbG/9tB/GSnQdVSj3G8MS80iLS58frnt+RSEw/ psahrfh0dh6SFHttE049xYiC+cM8J27Aaf0i9RflyITq57NuJm+AHJoU9SQUkIF0nc6lfA+o JRiyRlHZHKoRQkIg4aiKaZSWjQYRl5Txl0IZUP1dSWMX4s3XTMurC/pnja45dge/4ESOtJ9R 8XuIWg45Oq6MeIWdjKddGhRj3OohsltKgkEU3eLKYtB6qRTQypHHUawCXz88uYt5e3w4V16H lCpSTZV/EVHnNe45FVBlvK7k7HFfDDkryM7BTQRZuCyIARAAlq0slcsVboY/+IUJdcbEiJRW be9HKVz4SUchq0z9MZPX/0dcnvz/gkyYA+OuM78dNS7Mbby5dTvOqfpLJfCuhaNYOhlE0wY+ 1T6Tf1f4c/uA3U/YiadukQ3+6TJuYGAdRZD5EqYFIkreARTVWg87N9g0fT9BEqLw9lJtEGDY EWUE7L++B8o4uu3LQFEYxcrb4K/WKmgtmFcm77s0IKDrfcX4doV92QTIpLiRxcOmCC/OCYuO jB1oaaqXQzZrCutXRK0L5XN1Y1PYjIrEzHMIXmCDlLYnpFkK+itlXwlE2ZQxkfMruCWdQXye syl2fynAe8hvp7Mms9qU2r2K9EcJiR5N1t1C2/kTKNUhcRv7Yd/vwusK7BqJbhlng5ZgRx0m WxdntU/JLEntz3QBsBsWM9Y9wf2V4tLv6/DuDBta781RsCB/UrU2zNuOEkSixlUiHxw1dccI 6CVlaWkkJBxmHX22GdDFrcjvwMNIbbyfQLuBq6IOh8nvu9vuItup7qemDG3Ms6TVwA7BD3j+ 3fGprtyW8Fd/RR2bW2+LWkMrqHffAr6Y6V3h5kd2G9Q8ZWpEJk+LG6Mk3fhZhmCnHhDu6CwN MeUvxXDVO+fqc3JjFm5OxhmfVeJKrbCEUJyM8ESWLoNHLqjywdZga4Q7P12g8DUQ1mRxYg/L HgZY3zfKOqcAEQEAAcLBfAQYAQgAJhYhBL4sQ7ueBCdcDgGOvnfybtNRzXKPBQJZuCyIAhsM BQkFo5qAAAoJEHfybtNRzXKPBVwQAKfFy9P7N3OsLDMB56A4Kf+ZT+d5cIx0Yiaf4n6w7m3i ImHHHk9FIetI4Xe54a2IXh4Bq5UkAGY0667eIs+Z1Ea6I2i27Sdo7DxGwq09Qnm/Y65ADvXs 3aBvokCcm7FsM1wky395m8xUos1681oV5oxgqeRI8/76qy0hD9WR65UW+HQgZRIcIjSel9vR XDaD2HLGPTTGr7u4v00UeTMs6qvPsa2PJagogrKY8RXdFtXvweQFz78NbXhluwix2Tb9ETPk LIpDrtzV73CaE2aqBG/KrboXT2C67BgFtnk7T7Y7iKq4/XvEdDWscz2wws91BOXuMMd4c/c4 OmGW9m3RBLufFrOag1q5yUS9QbFfyqL6dftJP3Zq/xe+mr7sbWbhPVCQFrH3r26mpmy841ym dwQnNcsbIGiBASBSKksOvIDYKa2Wy8htPmWFTEOPRpFXdGQ27awcjjnB42nngyCK5ukZDHi6 w0qK5DNQQCkiweevCIC6wc3p67jl1EMFY5+z+zdTPb3h7LeVnGqW0qBQl99vVFgzLxchKcl0 R/paSFgwqXCZhAKMuUHncJuynDOP7z5LirUeFI8qsBAJi1rXpQoLJTVcW72swZ42IdPiboqx NbTMiNOiE36GqMcTPfKylCbF45JNX4nF9ElM0E+Y8gi4cizJYBRr2FBJgay0b9Cp Message-ID: <19c0f590-4327-d2c8-4660-bd9f5df12b50@FreeBSD.org> Date: Wed, 27 Feb 2019 15:10:00 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <201902271304.x1RD4S6U051477@slippy.cwsent.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3A38475D52 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.987,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 13:10:11 -0000 On 27/02/2019 15:04, Cy Schubert wrote: > In message <0563e72c-c9e3-a476-ce43-d4a67c454508@FreeBSD.org>, Andriy > Gapon wri > tes: >> On 26/02/2019 22:58, Cy Schubert wrote: >>> I was talking about nested datasets, i.e. tank/freebsd/git/current and >>> tank/freebsd/git/ports are four levels deep. >> >> We usually don't call them "nested". In fact, I don't think that we call the >> m >> anything special because having N levels deep datasets (N > 1) is just a comm >> on >> thing. We may call them subordinate or child datasets when mentioning a >> relation to a parent dataset. >> >>> In my case the ports >>> dataset was mounted while the current dataset was not, though zfs >>> believed it was. unmounting the current dataset and remounting it, zfs >>> umount .../current; zfs mount .../current worked around the issue. >> >> Are you sure that it was not mounted? > > Yes. > >> Have you checked that by looking at mount output? > > Yes > >> I suspect that it was mounted, just not where you expected and its mount path >> was covered by another filesystem. > > If you read my original email Apologies, I failed to read your original email when I first saw it. I pressed Page Down a few times but was still seeing only a quoted text, so I gave up. > a zfs umount followed by a zfs mount for > each affected filesystem worked around the problem. zfs properties > showed that each and every filesystem was mounted. mount(1) and df(1) > confirmed they were not. Furthermore nullfs mounts with the late > attribute failed to mount because their underlying zfs datasets were > not mounted -- this is what clued me into the problem in the first > place, a FreeBSD system dropping into single user at boot. And, no, > fstab on that machine had not been changed for months, them machine > failed to boot. So, no, I was not mistaken. I was rather displeased > because I had to try to fix the problem using ssh on a phone to a > machine connected to a console server. > >> >> E.g., lets consider this hypothetical case. >> I have two same level datasets tank/freebsd/src and tank/freebsd/sys where >> tank/freebsd/src is mounted at /usr/src and tank/freebsd/sys is mounted at >> /usr/src/sys (a child directory of /usr/src). >> If tank/freebsd/src is mounted first, then everything is okay, tank/freebsd/s >> ys >> would be mounted on top of sys directory in tank/freebsd/src. >> If, however, tank/freebsd/sys is mounted first (assuming that path /usr/src/s >> ys >> exists in a root filesystem), then mounting tank/freebsd/src would simply hid >> e >> tank/freebsd/sys "below" it as /usr/src/sys would be sys directory in >> tank/freebsd/src. >> >> I guess that this is a kind of problem that could be introduced with parallel >> mounting. And I guess that this is a kind of problem that you might actually >> have. But it's just a guess. > > No. I had not mistakenly mounted the datasets elsewhere, mistakenly > deleted them or mistakenly changed their mount attributes. It was a > real, not imagined, regression fixed by the patch posted near the end > of the email thread. Okay. Great that it is fixed and sorry for my noise. -- Andriy Gapon