From owner-freebsd-ports@FreeBSD.ORG  Tue Jun 10 18:10:32 2008
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 94BFC1065673
	for <ports@freebsd.org>; Tue, 10 Jun 2008 18:10:32 +0000 (UTC)
	(envelope-from mezz7@cox.net)
Received: from eastrmmtao101.cox.net (eastrmmtao101.cox.net [68.230.240.7])
	by mx1.freebsd.org (Postfix) with ESMTP id 1CD688FC0C
	for <ports@freebsd.org>; Tue, 10 Jun 2008 18:10:31 +0000 (UTC)
	(envelope-from mezz7@cox.net)
Received: from eastrmimpo01.cox.net ([68.1.16.119]) by eastrmmtao101.cox.net
	(InterMail vM.7.08.02.01 201-2186-121-102-20070209) with ESMTP id
	<20080610181030.SONI25509.eastrmmtao101.cox.net@eastrmimpo01.cox.net>;
	Tue, 10 Jun 2008 14:10:30 -0400
Received: from mezz.mezzweb.com ([24.255.149.218])
	by eastrmimpo01.cox.net with bizsmtp
	id cJAW1Z0044iy4EG02JAWwB; Tue, 10 Jun 2008 14:10:30 -0400
Date: Tue, 10 Jun 2008 13:13:00 -0500
To: "Kris Kennaway" <kris@freebsd.org>
From: "Jeremy Messenger" <mezz7@cox.net>
Content-Type: text/plain; format=flowed; delsp=yes; charset=us-ascii
MIME-Version: 1.0
References: <484EAFAC.3020208@FreeBSD.org>
Content-Transfer-Encoding: Quoted-Printable
Message-ID: <op.ucjovyxo9aq2h7@mezz.mezzweb.com>
In-Reply-To: <484EAFAC.3020208@FreeBSD.org>
User-Agent: Opera Mail/9.27 (Linux)
Cc: ports@freebsd.org
Subject: Re: INDEX build optimizations - please review
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Jun 2008 18:10:32 -0000

On Tue, 10 Jun 2008 11:45:32 -0500, Kris Kennaway <kris@FreeBSD.org> wro=
te:

> Another important optimization is to use /rescue/sh instead of /bin/sh=
  =

> for index builds.  The former is statically linked and this is much  =

> faster to execute.

I don't have INDEX in all of my systems, so I am only take a peek. What =
 =

about users that have WITHOUT_RESCUE defined or/and something different?=
  =

IMO, I think your patch should have a check on if /rescue/sh exists when=
  =

our src provides optional of WITHOUT_RESCUE and is harmless to kill the =
 =

/rescue.

------------------------------
.if exists(/rescue/sh)
__MAKE_SHELL=3D/rescue/sh
.else
__MAKE_SHELL=3D/bin/sh
.endif
------------------------------

Thanks for hint on 'NOTE TO PORT DEVELOPERS' part as I didn't know about=
  =

VARIABLE!=3D vs $(${VARIABLE_CMDS}). /me copies it in my note.


--


As for the audio/festvox-hvs issue, probably because of no executables o=
r  =

files in RUN_DEPENDS:

------------------------------
RUN_DEPENDS=3D	${PORTSDIR}/audio/festival+OGI \
		${PORTSDIR}/audio/festlex-poslex \
		${PORTSDIR}/audio/festlex-ogi \
		${PORTSDIR}/audio/festogi-spanish
------------------------------

Cheers,
Mezz


-- =

mezz7@cox.net  -  mezz@FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/  -  gnome@FreeBSD.org