Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 18 Feb 2015 23:28:17 +0000
From:      Steven Hartland <steven@multiplay.co.uk>
To:        Rui Paulo <rpaulo@me.com>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r277300 - in head: cddl/contrib/opensolaris/cmd/dtrace cddl/contrib/opensolaris/cmd/lockstat cddl/contrib/opensolaris/cmd/mdb/tools/common cddl/contrib/opensolaris/cmd/plockstat cddl/co...
Message-ID:  <54E52011.9040502@freebsd.org>
In-Reply-To: <5f8079b1-ae7d-4977-99f6-a8fd0f3f8252@me.com>
References:  <5f8079b1-ae7d-4977-99f6-a8fd0f3f8252@me.com>

next in thread | previous in thread | raw e-mail | index | archive | help

On 18/02/2015 18:36, Rui Paulo wrote:
> On Jan 17, 2015, at 06:45 AM, Steven Hartland <smh@FreeBSD.org> wrote:
>
>> Author: smh
>> Date: Sat Jan 17 14:44:59 2015
>> New Revision: 277300
>> URL: https://svnweb.freebsd.org/changeset/base/277300
>>
>> Log:
>> Mechanically convert cddl sun #ifdef's to illumos
>>
>> Since the upstream for cddl code is now illumos not sun, mechanically
>> convert all sun #ifdef's to illumos #ifdef's which have been used in all
>> newer code for some time.
>>
>> Also do a manual pass to correct the use if #ifdef comments as per 
>> style(9)
>> as well as few uses of #if defined(__FreeBSD__) vs #ifndef illumos.
> I had just convinced Mark Johnston to use "#ifdef __FreeBSD__" instead 
> of "#ifndef illumos".  Is there a reason why we keep using #ifndef ? 
>  To me, it's much easier to read #ifdef __FreeBSD__ than to note 
> whether theres an "n" in that pre-processor macro.
>
None that I'm aware of, happy to go with that in the future :)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54E52011.9040502>