From owner-svn-src-all@FreeBSD.ORG Wed Feb 18 23:28:30 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E1F3DB01 for ; Wed, 18 Feb 2015 23:28:30 +0000 (UTC) Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6F590FF0 for ; Wed, 18 Feb 2015 23:28:30 +0000 (UTC) Received: by mail-wi0-f180.google.com with SMTP id h11so5683945wiw.1 for ; Wed, 18 Feb 2015 15:28:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type; bh=2ViFiMT57OvpjKyLgWoVoMYc1rcDLeDPfcKd5TNbwLM=; b=bB/RSyL4m0r5KlZfV5BTGbFtZlaeRjQYMj/9PyZP6ld/i6I2Tyg4FYdoFUChZnTKEU Ecj6MnUkidyU/If/Qrqr0RaA8HynADGy/bJaEUjL4uiR1JLwlK9sgKLvpKrxrIXIzVbZ bNTb9vBvX4KzFgi+RCB/CEBAJ4tZmcZCI5pgvwi5vJTLTNFbnn4azUWFAFJzUrHQ4f5y EQ8p7AfKcK0DgxrXBncGoXfTeeSyuEyd+KMphaBligqkHSs4i82Xzg87OT6iJ0l1DwzI L28kVqv05iMZnAhsuEdaIhybpPJBRw2uKFSB1M11G7S50B2vdcyVzsjygMFgcpVR/JIn hmxg== X-Gm-Message-State: ALoCoQkawrWoA4+YcFW4VLc/oPDt7g+hWeOtMZMlnPG2whEUsnU+D7kY/2A+RzI1H7eAONQwR8m1 X-Received: by 10.194.187.236 with SMTP id fv12mr3144156wjc.131.1424302102919; Wed, 18 Feb 2015 15:28:22 -0800 (PST) Received: from [10.10.1.68] (82-69-141-170.dsl.in-addr.zen.co.uk. [82.69.141.170]) by mx.google.com with ESMTPSA id gm2sm21528228wib.5.2015.02.18.15.28.20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Feb 2015 15:28:21 -0800 (PST) From: Steven Hartland X-Google-Original-From: Steven Hartland Message-ID: <54E52011.9040502@freebsd.org> Date: Wed, 18 Feb 2015 23:28:17 +0000 User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Rui Paulo Subject: Re: svn commit: r277300 - in head: cddl/contrib/opensolaris/cmd/dtrace cddl/contrib/opensolaris/cmd/lockstat cddl/contrib/opensolaris/cmd/mdb/tools/common cddl/contrib/opensolaris/cmd/plockstat cddl/co... References: <5f8079b1-ae7d-4977-99f6-a8fd0f3f8252@me.com> In-Reply-To: <5f8079b1-ae7d-4977-99f6-a8fd0f3f8252@me.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 23:28:31 -0000 On 18/02/2015 18:36, Rui Paulo wrote: > On Jan 17, 2015, at 06:45 AM, Steven Hartland wrote: > >> Author: smh >> Date: Sat Jan 17 14:44:59 2015 >> New Revision: 277300 >> URL: https://svnweb.freebsd.org/changeset/base/277300 >> >> Log: >> Mechanically convert cddl sun #ifdef's to illumos >> >> Since the upstream for cddl code is now illumos not sun, mechanically >> convert all sun #ifdef's to illumos #ifdef's which have been used in all >> newer code for some time. >> >> Also do a manual pass to correct the use if #ifdef comments as per >> style(9) >> as well as few uses of #if defined(__FreeBSD__) vs #ifndef illumos. > I had just convinced Mark Johnston to use "#ifdef __FreeBSD__" instead > of "#ifndef illumos". Is there a reason why we keep using #ifndef ? > To me, it's much easier to read #ifdef __FreeBSD__ than to note > whether theres an "n" in that pre-processor macro. > None that I'm aware of, happy to go with that in the future :)