From owner-svn-src-all@FreeBSD.ORG Sat Sep 5 08:38:25 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D0227106566B; Sat, 5 Sep 2009 08:38:25 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 8B3F78FC08; Sat, 5 Sep 2009 08:38:25 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n858cPPd042102; Sat, 5 Sep 2009 08:38:25 GMT (envelope-from imp@svn.freebsd.org) Received: (from imp@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n858cP6f042100; Sat, 5 Sep 2009 08:38:25 GMT (envelope-from imp@svn.freebsd.org) Message-Id: <200909050838.n858cP6f042100@svn.freebsd.org> From: Warner Losh Date: Sat, 5 Sep 2009 08:38:25 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r196858 - head/sys/dev/rp X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Sep 2009 08:38:25 -0000 Author: imp Date: Sat Sep 5 08:38:25 2009 New Revision: 196858 URL: http://svn.freebsd.org/changeset/base/196858 Log: These checks against BUSY aren't needed: the newbus layer does this already with the appropriate locks held... There's no need to do it here, so just delete the checks. Modified: head/sys/dev/rp/rp_pci.c Modified: head/sys/dev/rp/rp_pci.c ============================================================================== --- head/sys/dev/rp/rp_pci.c Sat Sep 5 08:09:35 2009 (r196857) +++ head/sys/dev/rp/rp_pci.c Sat Sep 5 08:38:25 2009 (r196858) @@ -225,11 +225,7 @@ rp_pcidetach(device_t dev) { CONTROLLER_t *ctlp; - if (device_get_state(dev) == DS_BUSY) - return (EBUSY); - ctlp = device_get_softc(dev); - rp_pcireleaseresource(ctlp); return (0); @@ -240,11 +236,7 @@ rp_pcishutdown(device_t dev) { CONTROLLER_t *ctlp; - if (device_get_state(dev) == DS_BUSY) - return (EBUSY); - ctlp = device_get_softc(dev); - rp_pcireleaseresource(ctlp); return (0);