From owner-freebsd-ports@FreeBSD.ORG Sat May 31 18:29:16 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 01AB56B8; Sat, 31 May 2014 18:29:16 +0000 (UTC) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "troutmask.apl.washington.edu", Issuer "troutmask.apl.washington.edu" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id D1DAB2087; Sat, 31 May 2014 18:29:15 +0000 (UTC) Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.14.8/8.14.8) with ESMTP id s4VITEaG061611 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 31 May 2014 11:29:14 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.14.8/8.14.8/Submit) id s4VITEeF061610; Sat, 31 May 2014 11:29:14 -0700 (PDT) (envelope-from sgk) Date: Sat, 31 May 2014 11:29:14 -0700 From: Steve Kargl To: Mark Linimon Subject: Re: please revert graphics/xfig r354029 Message-ID: <20140531182914.GA61533@troutmask.apl.washington.edu> References: <20140531000800.GA57984@troutmask.apl.washington.edu> <5389D9B6.8030005@FreeBSD.org> <20140531143509.GA60572@troutmask.apl.washington.edu> <5389EE92.5070105@FreeBSD.org> <20140531150936.GA60696@troutmask.apl.washington.edu> <20140531173128.GA6980@lonesome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140531173128.GA6980@lonesome.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Guido Falsi , freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 May 2014 18:29:16 -0000 On Sat, May 31, 2014 at 12:31:28PM -0500, Mark Linimon wrote: > On Sat, May 31, 2014 at 08:09:36AM -0700, Steve Kargl wrote: > > I forgot I had the DOCS option unset as it was unset ages ago > > and updates have always worked. The question is "why are changes > > to a port committed without proper testing?" Yes, "proper > > testing" should include testing of the effects of (un)setting > > individual Makefile options. > > The number of combinations is huge. There are 3 options for graphics/xfig. It takes all of 5 minutes to build and install xfig on a 5 year old laptop. The options are mutually exclusive, so one needs to build and install the port 4 times (i.e., a whole 20 to 25 minutes). > > It's just not feasible. > I'm not advocating that portmgr should set up the testing on the FreeBSD cluster. The testing should be done by the individual maintainers. If s/he includes 3 (or 2 dozen) options in the Makefile, then s/he should test those options when s/he changes/updates the port. If it is too inconvenient or too labor intensive to test the options (i.e., 2 dozen options), then perhaps the options aren't too terribly important and should be removed. > Even if it were, we have 2042 ports PRs (171 or so are about staging), > and those ought to be our priorites IMHO. Yes, those should be the priorities. Hopefully, any change to a port (that addresses one of these PRs) is properly tested. -- Steve