Date: Fri, 25 Jan 2019 09:55:12 +0000 From: Edward Napierala <trasz@freebsd.org> To: rgrimes@freebsd.org Cc: Devin Teske <dteske@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343440 - head/bin/sh Message-ID: <20190125095512.GB26744@v2> In-Reply-To: <201901260105.x0Q15YwH091095@pdx.rh.CN85.dnsmgr.net> References: <6DD219EC-C898-499E-BF58-AB653A7114DB@FreeBSD.org> <201901260105.x0Q15YwH091095@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 0125T1705, Rodney W. Grimes wrote: > > > On Jan 25, 2019, at 1:13 AM, Edward Napierala <trasz@freebsd.org> wrote: > > Chop with the big axe most of this as I need to clarify a miss statement. > ... > > > The change we're discussing doesn't affect upgrades at all - it's only > > > for new installs. > > > > mergemaster, iirc, will merge in changes to etc files after an upgrade. > > So this would effect anybody that goes through an upgrade and performs mergemaster. > > Correct, and to my knowledge there is no way to stop that effect. Won't happen in this case, this doesn't apply to files in /etc at all; it only applies to the default /root/.shrc and /root/.profile that get installed on fresh systems. > > > And it doesn't affect root by default, you > > > need to change their shell from csh(1) to sh(1). > > > > By your own commit messages admission, this is for the toor account, so it does affect a user (and as you were keen to point out, users with the default shell). > > Further it effects root any time root types "sh" or "/bin/sh" > and intentially invokes sh interactive for some reason, > something I do more often than I care to admit simply > cause I know what I want to do is much easier in that > shell. It doesn't. For sh(1) to read ~/.shrc (/root/.shrc in this case) you need to have ENV set; the default /root/.profile only sets it when sh(1) is your login shell. Which means, this doesn't change the behaviour when you casually run "sh" or "/bin/sh" as root; sh needs to be set up as login shell for this to take effect.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190125095512.GB26744>