From owner-svn-src-head@freebsd.org  Thu Nov 21 16:28:56 2019
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 244D81C42E4
 for <svn-src-head@mailman.nyi.freebsd.org>;
 Thu, 21 Nov 2019 16:28:56 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from outbound2m.ore.mailhop.org (outbound2m.ore.mailhop.org
 [54.149.155.156])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 47JlPM5DfTz4cdB
 for <svn-src-head@freebsd.org>; Thu, 21 Nov 2019 16:28:55 +0000 (UTC)
 (envelope-from ian@freebsd.org)
ARC-Seal: i=1; a=rsa-sha256; t=1574353734; cv=none;
 d=outbound.mailhop.org; s=arc-outbound20181012;
 b=b9ykdyi2SkmN5IEyeBhHz+S3gnDDgzXUtvKlTxaxE4dbnRvINYCRZyVSINnJsW/hqsvTGQ+GkqRqb
 icLelnx8sWf/1KXLmeXeoEIm9nqplyKSFcUG6PZkeB+IM8UsGwIe2pNOv2yDmWwkgboMkUccM+c8eO
 sWfLvhuNjsl2K9Q+Me/BcjmBRnu17Dgy6SwBBGbNMaC/PZ3W2fCZHc30nQW2bsjLjLOKQwnnLkc7Hw
 ltTfHLfbWUMXS76Y8QJtI7oVtOX8OIoWdjBoBFsCNOO2lw9ASV091cuJtXT2waAZ3rtltq613qnhUx
 KpL54nG2MybNu3t6kkZH+Xze9NXdnNw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed;
 d=outbound.mailhop.org; s=arc-outbound20181012;
 h=content-transfer-encoding:mime-version:content-type:references:in-reply-to:
 date:cc:to:from:subject:message-id:dkim-signature:from;
 bh=aWCvtw0smVbLH+WIMF8FGX8heQSj25J1dL0TVnonqHo=;
 b=NC+5I8LaQ2GqwDOPJ7pHaVZG+xIU6pDYMyr7iGkFmAlmIKRaojyNQUarecdRJhm50RUfuzcu+hvFn
 ziStvZN3Eodf6fBi6+kDLGHONDAVe2+oLmRKkgoiXtOp456g1azTmy143kzf7ndud2R17JihfUCJxy
 Sw6qNQtKsnwExmW9afaz4KOJ10an7735JGDejYfRmWgtXq+HfwUYQaEsTyFSSkk1uZ3VO5SiMtZc+2
 HX6BYGg7bT83ajMjPMhGUKEdlnfj7h+tBJSyMFCRHvRrjpK/bsPYtxCxj2M2p8xhhBvAR2e2c5UXZg
 Ro2qUha5Bn9Q7KA78SyM3C6fQ4fAwxg==
ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org;
 spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60;
 dmarc=none header.from=freebsd.org;
 arc=none header.oldest-pass=0;
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=outbound.mailhop.org; s=dkim-high;
 h=content-transfer-encoding:mime-version:content-type:references:in-reply-to:
 date:cc:to:from:subject:message-id:from;
 bh=aWCvtw0smVbLH+WIMF8FGX8heQSj25J1dL0TVnonqHo=;
 b=N0mKiEvs3Yn8SSD5Mxy9Ag5DHKtUHj7J0qFW4VN/n2ODQwCQ5eTflU2LDbMgWriyobkFUXXUu9FaF
 e30Vm82qqvAPuhYDFrAYuueL8IOFd4L1iDaD5e4wsD2lILm30JwY97DImfZRvLG17XZPXFOh0mODP2
 zTYUIiL2T/BkgtqaFIoJP4EngcJSNSZh4sdUIcuW6ZCQK2C4Twgskc/CE9rADA93naLPfbIOKlGUwh
 FFyvv1LjJSa8eyTLDc9Bs0wklkYZmv2maGJdRN3cj9fmq5taWIjlFguQve+hqLpoZ0b/VFQHfFldu2
 qnzwBdgFHjS9cS7Fn1VLdbRs/6YInbg==
X-MHO-RoutePath: aGlwcGll
X-MHO-User: 007092ea-0c7c-11ea-829e-79a40d15cccd
X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information
X-Originating-IP: 67.177.211.60
X-Mail-Handler: DuoCircle Outbound SMTP
Received: from ilsoft.org (unknown [67.177.211.60])
 by outbound4.ore.mailhop.org (Halon) with ESMTPSA
 id 007092ea-0c7c-11ea-829e-79a40d15cccd;
 Thu, 21 Nov 2019 16:28:52 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.15.2/8.15.2) with ESMTP id xALGSo7P054684;
 Thu, 21 Nov 2019 09:28:50 -0700 (MST) (envelope-from ian@freebsd.org)
Message-ID: <3ed399dae42291005a5b88e426018697b47d8419.camel@freebsd.org>
Subject: Re: svn commit: r354909 - in head: . share/mk
From: Ian Lepore <ian@freebsd.org>
To: Glen Barber <gjb@freebsd.org>, Brooks Davis <brooks@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org, FreeBSD Ports Management Team
 <portmgr@freebsd.org>, Colin Percival <cperciva@freebsd.org>
Date: Thu, 21 Nov 2019 09:28:50 -0700
In-Reply-To: <20191121162311.GN5599@FreeBSD.org>
References: <201911201836.xAKIawWt053874@repo.freebsd.org>
 <20191121161337.GA92849@FreeBSD.org> <20191121162311.GN5599@FreeBSD.org>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 47JlPM5DfTz4cdB
X-Spamd-Bar: -
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-1.94 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 NEURAL_HAM_MEDIUM(-0.97)[-0.966,0];
 NEURAL_HAM_LONG(-0.98)[-0.978,0];
 ASN(0.00)[asn:16509, ipnet:54.148.0.0/15, country:US]
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Nov 2019 16:28:56 -0000

On Thu, 2019-11-21 at 16:23 +0000, Glen Barber wrote:
> On Thu, Nov 21, 2019 at 04:13:37PM +0000, Glen Barber wrote:
> > On Wed, Nov 20, 2019 at 06:36:58PM +0000, Brooks Davis wrote:
> > > Author: brooks
> > > Date: Wed Nov 20 18:36:58 2019
> > > New Revision: 354909
> > > URL: https://svnweb.freebsd.org/changeset/base/354909
> > > 
> > > Log:
> > >   Make the warning for deprecated NO_ variables an error.
> > >   
> > >   Support for NO_CTF, NO_DEBUG_FILES, NO_INSTALLLIB, NO_MAN,
> > > NO_PROFILE,
> > >   and NO_WARNS as deprecated in 2014 with a warning added for
> > > each one
> > >   found. Turn these into error in preperation for removal of
> > > compatability
> > >   support before FreeBSD 13.
> > >   
> > >   Reviewed by:	imp
> > >   Relnotes:	yes
> > >   Sponsored by:	DARPA, AFRL
> > >   Differential Revision:	https://reviews.freebsd.org/D22448
> > > 
> > > Modified: head/share/mk/bsd.opts.mk
> > > =================================================================
> > > =============
> > > --- head/share/mk/bsd.opts.mk	Wed Nov 20 18:12:01 2019	(
> > > r354908)
> > > +++ head/share/mk/bsd.opts.mk	Wed Nov 20 18:36:58 2019	(
> > > r354909)
> > > @@ -100,7 +100,7 @@ __DEFAULT_DEPENDENT_OPTIONS = \
> > >      PROFILE \
> > >      WARNS
> > >  .if defined(NO_${var})
> > > -.warning "NO_${var} is defined, but deprecated. Please use
> > > MK_${var}=no instead."
> > > +.error "NO_${var} is defined, but deprecated. Please use
> > > MK_${var}=no instead."
> > >  MK_${var}:=no
> > >  .endif
> > >  .endfor
> > > 
> > 
> > Had this been exp-run tested?  This breaks at least the
> > net/bsdec2-image-upload port, which does *not* set NO_MAN
> > explicitly in
> > its Makefile.  I suspect at least several other ports are now
> > implicitly
> > broken as result of this change.
> > 
> 
> In fact, on a quick search through ports/*/*/Makefile, I do not see
> NO_MAN defined *anywhere*.  So, this is pulled in from somewhere
> else,
> which now I have a feeling more ports than I initially thought are
> now
> broken.
> 

Your search was too narrow.  Re-do it as "grep -Rw NO_MAN *" from
/usr/ports and you'll get a lot of hits from within files/ dirs.

-- Ian